Bug 1466731 [wpt PR 11337] - [LayoutNG] Fix flex BODY in quirks mode, a=testonly
authorAleks Totic <atotic@chromium.org>
Mon, 25 Jun 2018 22:10:59 +0000
changeset 424266 fe0ea401e3cf9180ae54f797804ae05f6556fe0d
parent 424265 903a5534c20fa9e793183b93a91b691b32b11768
child 424267 346ff23e0802f0302bf70988595a7cb635a1e44d
push id34201
push usershindli@mozilla.com
push dateThu, 28 Jun 2018 21:54:04 +0000
treeherdermozilla-central@8f49b2a0e003 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1466731, 11337, 849490, 1086381, 564629
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1466731 [wpt PR 11337] - [LayoutNG] Fix flex BODY in quirks mode, a=testonly Automatic update from web-platform-tests[LayoutNG] Fix flex BODY in quirks mode We were not updating margins correctly inside NGBlockNode::RunOldLayout. Symptom was that BODY(flex) block size was too big when HTML had margins inside quirks mode. Another side effect of this fix is two crashes have gone away. Added explicit test case for BODY(flex) in quirks mode. Bug: 849490 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id0ce0910144c81fc254646110424f36c898f9ebd Reviewed-on: https://chromium-review.googlesource.com/1086381 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#564629} -- wpt-commits: 8bafc093504c38befdb4e63d9d1d1dcee9bf81e4 wpt-pr: 11337
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-flexbox/flexbox_quirks_body.html
testing/web-platform/tests/css/css-flexbox/reference/flexbox_quirks_body-ref.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -115508,16 +115508,28 @@
       [
        "/css/css-flexbox/flexbox_order-ref.html",
        "=="
       ]
      ],
      {}
     ]
    ],
+   "css/css-flexbox/flexbox_quirks_body.html": [
+    [
+     "/css/css-flexbox/flexbox_quirks_body.html",
+     [
+      [
+       "/css/css-flexbox/reference/flexbox_quirks_body-ref.html",
+       "=="
+      ]
+     ],
+     {}
+    ]
+   ],
    "css/css-flexbox/flexbox_rowspan-overflow-automatic.html": [
     [
      "/css/css-flexbox/flexbox_rowspan-overflow-automatic.html",
      [
       [
        "/css/css-flexbox/flexbox_rowspan-ref.html",
        "=="
       ]
@@ -242006,16 +242018,21 @@
      {}
     ]
    ],
    "css/css-flexbox/reference/flexbox-flex-wrap-nowrap-ref.htm": [
     [
      {}
     ]
    ],
+   "css/css-flexbox/reference/flexbox_quirks_body-ref.html": [
+    [
+     {}
+    ]
+   ],
    "css/css-flexbox/reference/flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom-ref.html": [
     [
      {}
     ]
    ],
    "css/css-flexbox/reference/justify-content-001-ref.html": [
     [
      {}
@@ -506435,16 +506452,20 @@
   "css/css-flexbox/flexbox_order-ref.html": [
    "3708952dd2bec731a8235c17da05faccc4848f5d",
    "support"
   ],
   "css/css-flexbox/flexbox_order.html": [
    "3f8ea7d7e6b8ab8d0473aebfdedc108c34f732a1",
    "reftest"
   ],
+  "css/css-flexbox/flexbox_quirks_body.html": [
+   "b39447c4a7eba1ec321ae469fbd6442b1ef05445",
+   "reftest"
+  ],
   "css/css-flexbox/flexbox_rowspan-overflow-automatic.html": [
    "d13114027f1508a37406ad333f8b39882eba9fe8",
    "reftest"
   ],
   "css/css-flexbox/flexbox_rowspan-overflow.html": [
    "230ece34944910fa333ee861d0c3b2a87fd9f518",
    "reftest"
   ],
@@ -507187,16 +507208,20 @@
   "css/css-flexbox/reference/flexbox-flex-direction-ref.htm": [
    "d87ca62c074b1d6e7abc9fc5d846e756a61c7af4",
    "support"
   ],
   "css/css-flexbox/reference/flexbox-flex-wrap-nowrap-ref.htm": [
    "a69d1222f1ea291ef87ca0e996de93171aca28aa",
    "support"
   ],
+  "css/css-flexbox/reference/flexbox_quirks_body-ref.html": [
+   "307f46b4cedc1acf40c0a267b1175098a51c7245",
+   "support"
+  ],
   "css/css-flexbox/reference/flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom-ref.html": [
    "696a426eca7e126eef17fc995bbe794ae60af0ca",
    "support"
   ],
   "css/css-flexbox/reference/justify-content-001-ref.html": [
    "f6f0a1329ba712ff2948274b5ec13537e44d28fb",
    "support"
   ],
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-flexbox/flexbox_quirks_body.html
@@ -0,0 +1,20 @@
+<!doctype quirks><!-- Intentional quirks mode -->
+<title>CSS Test: Flex body in quirks mode</title>
+<link rel="author" title="Aleks Totic" href="atotic@chromium.org">
+<link rel="help" href="https://www.w3.org/TR/css-flexbox-1/#main-sizing" title="9.3 Main Size Determination">
+<link rel="help" href="https://quirks.spec.whatwg.org/#the-body-element-fills-the-html-element-quirk" title="The body element fills the html element quirk">
+<link rel="match" href="./reference/flexbox_quirks_body-ref.html">
+<style>
+html {
+  margin:3px 6px 9px 12px;
+  padding: 0px;
+  background-color: green;
+}
+body {
+  display: flex;
+  margin: 7px 11px 14px 23px;
+  padding: 0px;
+  background-color: yellow;
+}
+</style>
+Flex body in quirks mode should fill viewport except for margins.
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-flexbox/reference/flexbox_quirks_body-ref.html
@@ -0,0 +1,17 @@
+<!doctype quirks>
+<title>CSS Test: Flex body in quirks mode</title>
+<link rel="author" title="Aleks Totic" href="atotic@chromium.org">
+<style>
+html {
+  margin:3px 6px 9px 12px;
+  padding: 0px;
+  background-color: green;
+}
+body {
+  display: block;
+  margin: 7px 11px 14px 23px;;
+  padding: 0px;
+  background-color: yellow;
+}
+</style>
+Flex body in quirks mode should fill viewport except for margins.