Bug 1516114 - Enable 3-tier PGO for Linux; r=firefox-build-system-reviewers,Callek,chmanchester
authorMike Shal <mshal@mozilla.com>
Fri, 12 Apr 2019 20:54:40 +0000
changeset 469522 fdbd2c02f391
parent 469521 ca2c4053e33c
child 469523 f068f655d8df
push id35873
push userccoroiu@mozilla.com
push dateMon, 15 Apr 2019 21:36:26 +0000
treeherdermozilla-central@b8f49a14c458 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfirefox-build-system-reviewers, Callek, chmanchester
bugs1516114, 1519424
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1516114 - Enable 3-tier PGO for Linux; r=firefox-build-system-reviewers,Callek,chmanchester Now that 3-tier PGO uses a debian9 image to generate the profile data (bug 1519424), we no longer see the XDG_RUNTIME_DIR failures in the run task. The frequency of those errors was the primary blocker for enabling 3-tier PGO in the first place. Since we still see those errors occasionally in 1-tier PGO, we should switch to the 3-tier model for Linux. Differential Revision: https://phabricator.services.mozilla.com/D27326
taskcluster/ci/build/linux.yml
taskcluster/ci/generate-profile/kind.yml
taskcluster/ci/instrumented-build/kind.yml
--- a/taskcluster/ci/build/linux.yml
+++ b/taskcluster/ci/build/linux.yml
@@ -793,48 +793,44 @@ linux64-asan/debug:
         - linux64-rust-size
         - linux64-cbindgen
         - linux64-sccache
         - linux64-nasm
         - linux64-node
 
 linux64-shippable/opt:
     description: "Linux64 Shippable"
-    # Disabled because bug 1516114 shows up much more often
-    # use-pgo: true
+    use-pgo: true
     attributes:
         shippable: true
         enable-full-crashsymbols: true
     shipping-phase: build
     shipping-product: firefox
     index:
         product: firefox
         job-name: linux64-opt
         type: shippable
     treeherder:
         platform: linux64-shippable/opt
-        # Bug 1516114
-        symbol: B
-        # symbol: Bpgo(B)
+        symbol: Bpgo(B)
     worker-type: aws-provisioner-v1/gecko-{level}-b-linux
     worker:
         max-run-time: 9000
     run:
         using: mozharness
         actions: [get-secrets, build, check-test]
         config:
             - builds/releng_base_firefox.py
             - builds/releng_base_linux_64_builds.py
             - taskcluster_nightly.py
         script: "mozharness/scripts/fx_desktop_build.py"
         secrets: true
         tooltool-downloads: public
         need-xvfb: true
-        # Bug 1516114
-        # mozconfig-variant: profile-use
+        mozconfig-variant: profile-use
     toolchains:
         - linux64-binutils
         - linux64-clang
         - linux64-rust
         - linux64-rust-size
         - linux64-cbindgen
         - linux64-nasm
         - linux64-node
--- a/taskcluster/ci/generate-profile/kind.yml
+++ b/taskcluster/ci/generate-profile/kind.yml
@@ -17,25 +17,25 @@ transforms:
 
 job-defaults:
     treeherder:
         symbol: Bpgo(run)
         kind: test
         tier: 1
 
 jobs:
-    linux64/pgo:
+    linux64-shippable/opt:
         description: "Linux64 Profile Generation"
         shipping-phase: build
         shipping-product: firefox
         index:
             product: firefox
             job-name: linux64-profile
         treeherder:
-            platform: linux64/pgo
+            platform: linux64-shippable/opt
         worker-type: aws-provisioner-v1/gecko-{level}-b-linux
         worker:
             max-run-time: 1200
             docker-image: {in-tree: debian9-amd64-build}
             artifacts:
                 - type: file
                   name: public/build/profdata.tar.xz
                   path: /builds/worker/artifacts/profdata.tar.xz
--- a/taskcluster/ci/instrumented-build/kind.yml
+++ b/taskcluster/ci/instrumented-build/kind.yml
@@ -17,22 +17,22 @@ transforms:
     - taskgraph.transforms.task:transforms
 
 job-defaults:
     treeherder:
         symbol: Bpgo(instr)
         tier: 1
 
 jobs:
-    linux64/pgo:
+    linux64-shippable/opt:
         description: "Linux64 Instrumented"
         shipping-phase: build
         shipping-product: firefox
         treeherder:
-            platform: linux64/pgo
+            platform: linux64-shippable/opt
         worker-type: aws-provisioner-v1/gecko-{level}-b-linux
         worker:
             max-run-time: 7200
             env:
                 PERFHERDER_EXTRA_OPTIONS: instrumented
         run:
             using: mozharness
             actions: [get-secrets, build]