Bug 1603772: Revert the error type change when instantiating segments with Cranelift; r=rhunt
authorBenjamin Bouvier <benj@benj.me>
Fri, 13 Dec 2019 19:35:58 +0000
changeset 507050 fbeac1746d504ac63ad910d9c103ca2d65377d73
parent 507049 b92d5b9b880a082ca7c9a61ad9addc88c35f5ab8
child 507051 b0fb09545a0128c4ffdc4806e9f97cb3281f133c
push id36922
push userncsoregi@mozilla.com
push dateMon, 16 Dec 2019 17:21:47 +0000
treeherdermozilla-central@27d0d6cc2131 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrhunt
bugs1603772
milestone73.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1603772: Revert the error type change when instantiating segments with Cranelift; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D57126
js/src/wasm/WasmModule.cpp
--- a/js/src/wasm/WasmModule.cpp
+++ b/js/src/wasm/WasmModule.cpp
@@ -517,17 +517,17 @@ bool Module::initSegments(JSContext* cx,
 
   Instance& instance = instanceObj->instance();
   const SharedTableVector& tables = instance.tables();
 
   // Bulk memory changes the error checking behavior: we apply segments
   // in-order and terminate if one has an out-of-bounds range.
   // We enable bulk memory semantics if shared memory is enabled.
 #ifdef ENABLE_WASM_BULKMEM_OPS
-  const bool eagerBoundsCheck = cx->options().wasmCranelift();
+  const bool eagerBoundsCheck = false;
 #else
   // Bulk memory must be available if shared memory is enabled.
   const bool eagerBoundsCheck =
       !cx->realm()->creationOptions().getSharedMemoryAndAtomicsEnabled();
 #endif
 
   if (eagerBoundsCheck) {
     // Perform all error checks up front so that this function does not perform