Bug 1465340 [wpt PR 11240] - [css-grid] Disable paint containment for ruby-text elements, a=testonly
authorManuel Rego Casasnovas <rego@igalia.com>
Wed, 06 Jun 2018 16:45:31 +0000
changeset 422219 fb3095f9f93e1412d95cc803d3e133fae355c67e
parent 422218 36f6043bab57b2908daf03f97f7e5f8361597777
child 422220 78810c2adfbf38d821711a8af53820e6c4ab68cb
push id34122
push userebalazs@mozilla.com
push dateMon, 11 Jun 2018 09:37:00 +0000
treeherdermozilla-central@9941eb8c3b29 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1465340, 11240, 847743, 847274, 843329, 1077387, 562776
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1465340 [wpt PR 11240] - [css-grid] Disable paint containment for ruby-text elements, a=testonly Automatic update from web-platform-tests[css-grid] Disable paint containment for ruby-text elements Text from the spec (https://drafts.csswg.org/css-contain/#containment-paint): "... if the element is an internal ruby element ... paint containment has no effect." The patch disables "contain: paint" for ruby-text elements. We need to modify the reference file for contain-paint-008 test because of an unrelated issue (see crbug.com/847743). Other internal ruby elements like ruby-base, ruby-base-container, and ruby-base-text-container are already inline elements so they don't need extra checks. The tests checking those contain-paint-005, contain-paint-006, and contain-paint-007 do not pass due to a different issue related to absolute positions and ruby (see crbug.com/847274). TestExpectations is updated to point to the actual problem. BUG=843329 TEST=external/wpt/css/css-contain/contain-paint-008.html Change-Id: I26814598a3b806b67264146386052cbdfff62847 Reviewed-on: https://chromium-review.googlesource.com/1077387 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#562776} -- wpt-commits: 2812a9c56bf4d38d2ccc09e31765fe8e62d4d743 wpt-pr: 11240
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-contain/reference/contain-paint-008-ref.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -495538,17 +495538,17 @@
    "eecbc6d0ea1638e8c853458ed59cfbd67d096ef0",
    "support"
   ],
   "css/css-contain/reference/contain-paint-007-ref.html": [
    "090aba85ddcf927a33de227157ac8e411fd5c268",
    "support"
   ],
   "css/css-contain/reference/contain-paint-008-ref.html": [
-   "9148bb5f9f1f4bfa70a056e0d744ffddad909c7d",
+   "deba6dbd69a33458e0ae5de8721ae10984864dc6",
    "support"
   ],
   "css/css-contain/reference/contain-paint-013-ref.html": [
    "c3d8d642f2b4b25df84170669222b61866ab3057",
    "support"
   ],
   "css/css-contain/reference/contain-size-001-ref.html": [
    "6f68316c3e9647eb6f71d299bb1d43e286899a7d",
--- a/testing/web-platform/tests/css/css-contain/reference/contain-paint-008-ref.html
+++ b/testing/web-platform/tests/css/css-contain/reference/contain-paint-008-ref.html
@@ -3,16 +3,14 @@
   <meta charset=utf-8>
   <title>CSS-contain test: paint containment on ruby-text</title>
   <link rel="author" title="Florian Rivoal" href="https://florian.rivoal.net">
 
 <style>
 rt {
   display: ruby-text;
   font-size: 1rem;
-  position: relative;
-  left: 4ch;
   font-family: monospace;
 }
 </style>
 
 <p>This test passes if you can see the word PASS below.
-<div><ruby><rt>PASS</rt></ruby></div>
+<div><ruby><rt><span style="margin-left: 4ch;"></span>PASS</rt></ruby></div>