Bug 1404746 - Ignore minimum_opera_version in WebExtensions manifest. r=bsilverberg, r=mixedpuppy
authorapoorvasingh17 <apoorvasingh2811@gmail.com>
Tue, 03 Oct 2017 01:00:53 +0530
changeset 384331 f9b0cdd852e9f4337305b27953235539b40ea28a
parent 384330 67b836888700bcf439aa71a6e4ddae7d83ab09ef
child 384332 c5c5b9eff4c09691af9e9b3b2f2b18a576c15775
push id32626
push userarchaeopteryx@coole-files.de
push dateWed, 04 Oct 2017 09:14:11 +0000
treeherdermozilla-central@294f332a3553 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbsilverberg, mixedpuppy
bugs1404746
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1404746 - Ignore minimum_opera_version in WebExtensions manifest. r=bsilverberg, r=mixedpuppy
toolkit/components/extensions/schemas/manifest.json
toolkit/components/extensions/test/xpcshell/test_ext_manifest_minimum_opera_version.js
toolkit/components/extensions/test/xpcshell/xpcshell.ini
--- a/toolkit/components/extensions/schemas/manifest.json
+++ b/toolkit/components/extensions/schemas/manifest.json
@@ -14,16 +14,21 @@
             "maximum": 2
           },
 
           "minimum_chrome_version":{
             "type": "string",
             "optional": true
           },
 
+          "minimum_opera_version":{
+            "type": "string",
+            "optional": true
+          },
+
           "applications": {
             "type": "object",
             "optional": true,
             "properties": {
               "gecko": {
                 "$ref": "FirefoxSpecificProperties",
                 "optional": true
               }
new file mode 100644
--- /dev/null
+++ b/toolkit/components/extensions/test/xpcshell/test_ext_manifest_minimum_opera_version.js
@@ -0,0 +1,13 @@
+/* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
+/* vim: set sts=2 sw=2 et tw=80: */
+"use strict";
+
+
+add_task(async function test_manifest_minimum_opera_version() {
+  let normalized = await ExtensionTestUtils.normalizeManifest({
+    "minimum_opera_version": "48",
+  });
+
+  equal(normalized.error, undefined, "Should not have an error");
+  equal(normalized.errors.length, 0, "Should not have warnings");
+});
--- a/toolkit/components/extensions/test/xpcshell/xpcshell.ini
+++ b/toolkit/components/extensions/test/xpcshell/xpcshell.ini
@@ -32,16 +32,17 @@ tags = webextensions in-process-webexten
 
 [test_csp_custom_policies.js]
 [test_csp_validator.js]
 [test_ext_contexts.js]
 [test_ext_json_parser.js]
 [test_ext_manifest_content_security_policy.js]
 [test_ext_manifest_incognito.js]
 [test_ext_manifest_minimum_chrome_version.js]
+[test_ext_manifest_minimum_opera_version.js]
 [test_ext_manifest_themes.js]
 [test_ext_schemas.js]
 [test_ext_schemas_async.js]
 [test_ext_schemas_allowed_contexts.js]
 [test_ext_schemas_interactive.js]
 [test_ext_schemas_revoke.js]
 [test_ext_themes_supported_properties.js]
 [test_ext_unknown_permissions.js]