Bug 935534 - Use UrlBar.ImageButton.Unused on Back/Fwd phone buttons (r=sriram)
authorLucas Rocha <lucasr@lucasr.org>
Fri, 08 Nov 2013 15:07:29 +0000
changeset 154143 f91777954222efda30a3e30da0dd71651b27a608
parent 154142 9a56cb111bf5f8b1fd0771b3c69f63ca136f7635
child 154144 5431745749bc2dcb79086e2c86d873de51c2b1d6
push id25625
push userryanvm@gmail.com
push dateFri, 08 Nov 2013 19:48:34 +0000
treeherdermozilla-central@a8fe75687113 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssriram
bugs935534
milestone28.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 935534 - Use UrlBar.ImageButton.Unused on Back/Fwd phone buttons (r=sriram)
mobile/android/base/resources/layout/browser_toolbar.xml
mobile/android/base/resources/values/styles.xml
--- a/mobile/android/base/resources/layout/browser_toolbar.xml
+++ b/mobile/android/base/resources/layout/browser_toolbar.xml
@@ -2,20 +2,20 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <merge xmlns:android="http://schemas.android.com/apk/res/android"
        xmlns:gecko="http://schemas.android.com/apk/res-auto">
 
     <ImageButton android:id="@+id/back"
-                 style="@style/UrlBar.ImageButton.Back"/>
+                 style="@style/UrlBar.ImageButton.Unused"/>
 
     <ImageButton android:id="@+id/forward"
-                 style="@style/UrlBar.ImageButton.Forward"/>
+                 style="@style/UrlBar.ImageButton.Unused"/>
 
     <org.mozilla.gecko.BrowserToolbarBackground android:id="@+id/url_bar_bg"
                                                 android:layout_width="fill_parent"
                                                 android:layout_height="fill_parent"
                                                 android:background="@drawable/url_bar_bg"/>
 
     <ImageView android:id="@+id/url_bar_entry"
                style="@style/UrlBar.Button"
--- a/mobile/android/base/resources/values/styles.xml
+++ b/mobile/android/base/resources/values/styles.xml
@@ -369,24 +369,16 @@
 
     <!-- URL bar - Image Button - Unused -->
     <style name="UrlBar.ImageButton.Unused">
         <item name="android:layout_width">0dip</item>
         <item name="android:layout_height">0dip</item>
         <item name="android:visibility">gone</item>
     </style>
 
-    <style name="UrlBar.ImageButton.Back" parent="UrlBar.ImageButton.Unused">
-        <item name="android:contentDescription">@string/back</item>
-    </style>
-
-    <style name="UrlBar.ImageButton.Forward" parent="UrlBar.ImageButton.Unused">
-        <item name="android:contentDescription">@string/forward</item>
-    </style>
-
     <!-- URL bar - Image Button - Icon -->
     <style name="UrlBar.ImageButton.Icon">
          <item name="android:layout_width">@dimen/browser_toolbar_icon_width</item>
          <item name="android:layout_height">@dimen/browser_toolbar_height</item>
          <item name="android:layout_weight">0.0</item>
     </style>
 
     <!-- TabsTray List -->