Remove unused functions from nsComputedDOMStyle. (Bug 756219, patch 1) r=bzbarsky
authorL. David Baron <dbaron@dbaron.org>
Fri, 18 May 2012 08:51:55 -0400
changeset 94364 f7a34e60aeec17d28e3e02fb86d7144145f6c72c
parent 94363 e917972dc75df6f08f86506c0bbc99c02b94f1f5
child 94365 a726c2e6cde7032058b1df2bcb7b0e9c90a8632d
push id22712
push userryanvm@gmail.com
push dateSat, 19 May 2012 00:52:01 +0000
treeherdermozilla-central@642d1a36702f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbzbarsky
bugs756219
milestone15.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Remove unused functions from nsComputedDOMStyle. (Bug 756219, patch 1) r=bzbarsky Remove unused DoGet* functions from nsComputedDOMStyle which are never called because the shorthand properties that they're for aren't listed in the value returned from GetQueryablePropertyMap (which is as it should be).
layout/style/nsComputedDOMStyle.cpp
layout/style/nsComputedDOMStyle.h
--- a/layout/style/nsComputedDOMStyle.cpp
+++ b/layout/style/nsComputedDOMStyle.cpp
@@ -1844,23 +1844,16 @@ nsComputedDOMStyle::DoGetMozBackgroundSi
       }
     }
   }
 
   return valueList;
 }
 
 nsIDOMCSSValue*
-nsComputedDOMStyle::DoGetPadding()
-{
-  // return null per spec.
-  return nsnull;
-}
-
-nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetPaddingTop()
 {
   return GetPaddingWidthFor(NS_SIDE_TOP);
 }
 
 nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetPaddingBottom()
 {
@@ -1933,23 +1926,16 @@ nsComputedDOMStyle::DoGetTableLayout()
   nsROCSSPrimitiveValue *val = GetROCSSPrimitiveValue();
   val->SetIdent(
     nsCSSProps::ValueToKeywordEnum(GetStyleTable()->mLayoutStrategy,
                                    nsCSSProps::kTableLayoutKTable));
   return val;
 }
 
 nsIDOMCSSValue*
-nsComputedDOMStyle::DoGetBorderStyle()
-{
-  // return null per spec.
-  return nsnull;
-}
-
-nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetBorderTopStyle()
 {
   return GetBorderStyleFor(NS_SIDE_TOP);
 }
 
 nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetBorderBottomStyle()
 {
@@ -2017,23 +2003,16 @@ nsComputedDOMStyle::DoGetBorderTopLeftRa
 nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetBorderTopRightRadius()
 {
   return GetEllipseRadii(GetStyleBorder()->mBorderRadius,
                          NS_CORNER_TOP_RIGHT, true);
 }
 
 nsIDOMCSSValue*
-nsComputedDOMStyle::DoGetBorderWidth()
-{
-  // return null per spec.
-  return nsnull;
-}
-
-nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetBorderTopWidth()
 {
   return GetBorderWidthFor(NS_SIDE_TOP);
 }
 
 nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetBorderBottomWidth()
 {
@@ -2072,23 +2051,16 @@ nsComputedDOMStyle::DoGetBorderLeftColor
 
 nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetBorderRightColor()
 {
   return GetBorderColorFor(NS_SIDE_RIGHT);
 }
 
 nsIDOMCSSValue*
-nsComputedDOMStyle::DoGetMarginWidth()
-{
-  // return null per spec.
-  return nsnull;
-}
-
-nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetMarginTopWidth()
 {
   return GetMarginWidthFor(NS_SIDE_TOP);
 }
 
 nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetMarginBottomWidth()
 {
@@ -2121,23 +2093,16 @@ nsComputedDOMStyle::DoGetOrient()
   nsROCSSPrimitiveValue *val = GetROCSSPrimitiveValue();
   val->SetIdent(
     nsCSSProps::ValueToKeywordEnum(GetStyleDisplay()->mOrient,
                                    nsCSSProps::kOrientKTable));
   return val;
 }
 
 nsIDOMCSSValue*
-nsComputedDOMStyle::DoGetOutline()
-{
-  // return null per spec.
-  return nsnull;
-}
-
-nsIDOMCSSValue*
 nsComputedDOMStyle::DoGetOutlineWidth()
 {
   nsROCSSPrimitiveValue* val = GetROCSSPrimitiveValue();
 
   const nsStyleOutline* outline = GetStyleOutline();
 
   nscoord width;
   if (outline->GetOutlineStyle() == NS_STYLE_BORDER_STYLE_NONE) {
--- a/layout/style/nsComputedDOMStyle.h
+++ b/layout/style/nsComputedDOMStyle.h
@@ -217,33 +217,30 @@ private:
   nsIDOMCSSValue* DoGetBackgroundPosition();
   nsIDOMCSSValue* DoGetBackgroundRepeat();
   nsIDOMCSSValue* DoGetBackgroundClip();
   nsIDOMCSSValue* DoGetBackgroundInlinePolicy();
   nsIDOMCSSValue* DoGetBackgroundOrigin();
   nsIDOMCSSValue* DoGetMozBackgroundSize();
 
   /* Padding properties */
-  nsIDOMCSSValue* DoGetPadding();
   nsIDOMCSSValue* DoGetPaddingTop();
   nsIDOMCSSValue* DoGetPaddingBottom();
   nsIDOMCSSValue* DoGetPaddingLeft();
   nsIDOMCSSValue* DoGetPaddingRight();
 
   /* Table Properties */
   nsIDOMCSSValue* DoGetBorderCollapse();
   nsIDOMCSSValue* DoGetBorderSpacing();
   nsIDOMCSSValue* DoGetCaptionSide();
   nsIDOMCSSValue* DoGetEmptyCells();
   nsIDOMCSSValue* DoGetTableLayout();
   nsIDOMCSSValue* DoGetVerticalAlign();
 
   /* Border Properties */
-  nsIDOMCSSValue* DoGetBorderStyle();
-  nsIDOMCSSValue* DoGetBorderWidth();
   nsIDOMCSSValue* DoGetBorderTopStyle();
   nsIDOMCSSValue* DoGetBorderBottomStyle();
   nsIDOMCSSValue* DoGetBorderLeftStyle();
   nsIDOMCSSValue* DoGetBorderRightStyle();
   nsIDOMCSSValue* DoGetBorderTopWidth();
   nsIDOMCSSValue* DoGetBorderBottomWidth();
   nsIDOMCSSValue* DoGetBorderLeftWidth();
   nsIDOMCSSValue* DoGetBorderRightWidth();
@@ -270,24 +267,22 @@ private:
 
   /* Box Shadow */
   nsIDOMCSSValue* DoGetBoxShadow();
 
   /* Window Shadow */
   nsIDOMCSSValue* DoGetWindowShadow();
 
   /* Margin Properties */
-  nsIDOMCSSValue* DoGetMarginWidth();
   nsIDOMCSSValue* DoGetMarginTopWidth();
   nsIDOMCSSValue* DoGetMarginBottomWidth();
   nsIDOMCSSValue* DoGetMarginLeftWidth();
   nsIDOMCSSValue* DoGetMarginRightWidth();
 
   /* Outline Properties */
-  nsIDOMCSSValue* DoGetOutline();
   nsIDOMCSSValue* DoGetOutlineWidth();
   nsIDOMCSSValue* DoGetOutlineStyle();
   nsIDOMCSSValue* DoGetOutlineColor();
   nsIDOMCSSValue* DoGetOutlineOffset();
   nsIDOMCSSValue* DoGetOutlineRadiusBottomLeft();
   nsIDOMCSSValue* DoGetOutlineRadiusBottomRight();
   nsIDOMCSSValue* DoGetOutlineRadiusTopLeft();
   nsIDOMCSSValue* DoGetOutlineRadiusTopRight();