Bug 1624793 part 3 - Handle JSOp::ThrowSetConst in BytecodeFallsThrough. r=iain
authorJan de Mooij <jdemooij@mozilla.com>
Wed, 25 Mar 2020 16:39:23 +0000
changeset 520482 f72280a54c6e1889d33de7a4e79d4fb0b3927c11
parent 520481 635cc9ec177ccc0d0f6dbd3c60a87318b7e6f3d4
child 520483 57e989c8a37cbe84810e37dce41331a77847bd66
push id37252
push usermalexandru@mozilla.com
push dateThu, 26 Mar 2020 15:34:27 +0000
treeherdermozilla-central@31360ced8ff8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersiain
bugs1624793
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1624793 part 3 - Handle JSOp::ThrowSetConst in BytecodeFallsThrough. r=iain Just a drive-by change to be more consistent with JSOp::Throw and JSOp::ThrowMsg. It also results in slightly more compact code in Baseline Interpreter and JIT. Differential Revision: https://phabricator.services.mozilla.com/D68166
js/src/vm/BytecodeUtil.h
--- a/js/src/vm/BytecodeUtil.h
+++ b/js/src/vm/BytecodeUtil.h
@@ -381,16 +381,17 @@ static inline bool BytecodeFallsThrough(
     case JSOp::Goto:
     case JSOp::Default:
     case JSOp::Return:
     case JSOp::RetRval:
     case JSOp::Retsub:
     case JSOp::FinalYieldRval:
     case JSOp::Throw:
     case JSOp::ThrowMsg:
+    case JSOp::ThrowSetConst:
     case JSOp::TableSwitch:
       return false;
     default:
       return true;
   }
 }
 
 static inline bool BytecodeIsJumpTarget(JSOp op) {