Bug 1572912 - Enable column-span preference to fix existing test failures. r=dbaron
authorTing-Yu Lin <tlin@mozilla.com>
Mon, 12 Aug 2019 04:32:34 +0000
changeset 487401 f719a2df1b9620b000575eb2ddb289988904f634
parent 487400 7434139de6062722110472a91f6718e7d380fcbe
child 487402 6db54eb9e2f79cdd3c3db6eab249dfba9d73bda6
child 487478 7d69a46e4542256b75d954951dc03bbb39e621dc
push id36420
push useraiakab@mozilla.com
push dateMon, 12 Aug 2019 09:55:30 +0000
treeherdermozilla-central@f719a2df1b96 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs1572912
milestone70.0a1
first release with
nightly linux32
f719a2df1b96 / 70.0a1 / 20190812095530 / files
nightly linux64
f719a2df1b96 / 70.0a1 / 20190812095530 / files
nightly mac
f719a2df1b96 / 70.0a1 / 20190812095530 / files
nightly win32
f719a2df1b96 / 70.0a1 / 20190812095530 / files
nightly win64
f719a2df1b96 / 70.0a1 / 20190812095530 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1572912 - Enable column-span preference to fix existing test failures. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D41496
layout/reftests/w3c-css/failures.list
layout/reftests/w3c-css/received/reftest.list
testing/web-platform/meta/css/css-multicol/inheritance.html.ini
testing/web-platform/meta/css/css-multicol/parsing/column-span-computed.html.ini
--- a/layout/reftests/w3c-css/failures.list
+++ b/layout/reftests/w3c-css/failures.list
@@ -306,19 +306,21 @@ fuzzy(0-225,0-1060) css-multicol/multico
 fuzzy(0-225,0-13600) css-multicol/multicol-nested-column-rule-001.xht
 fuzzy(0-94,0-256) css-multicol/multicol-rule-none-000.xht
 fuzzy-if(OSX&&!webrender,255-255,100-150) css-writing-modes/outline-inline-vlr-006.html
 
 #This test seems to pass only on Linux-opt build, on everything else
 #Therefore using fuzzy annotation as a catch all
 fuzzy(0-255,0-2808) css-multicol/multicol-rule-large-001.xht
 
-# fails because column-span property not implemented (Bug 616436)
-fails css-multicol/multicol-fill-auto-block-children-001.xht
-fails css-multicol/multicol-fill-auto-block-children-002.xht
+# multicol-fill-auto-block-children-ref.xht has been updated in wpt in
+# bug 1523595 Part 4. Updating to the upstream version should eliminate the
+# fuzzy-if on OSX for multicol-fill-auto-block-children-001.xht.
+pref(layout.css.column-span.enabled,true) fuzzy-if(OSX,255-255,2762-2762) css-multicol/multicol-fill-auto-block-children-001.xht
+pref(layout.css.column-span.enabled,true) css-multicol/multicol-fill-auto-block-children-002.xht
 pref(layout.css.column-span.enabled,true) fuzzy-if(winWidget,40-47,8-8) fuzzy-if(OSX,0-27,0-11) css-multicol/multicol-span-all-block-sibling-003.xht
 
 # skip these tests since they haven't been triaged yet.
 # These tests were added to the tree as part of an update for Bug 1430939.
 skip css-multicol/multicol-fill-balance-002.html
 skip css-multicol/multicol-gap-fraction-002.html
 skip css-multicol/multicol-rule-shorthand-2.xht
 skip css-multicol/multicol-width-ch-001.xht
--- a/layout/reftests/w3c-css/received/reftest.list
+++ b/layout/reftests/w3c-css/received/reftest.list
@@ -83,18 +83,18 @@ fuzzy(0-204,0-930) fuzzy-if(skiaContent,
 fuzzy(0-204,0-930) fuzzy-if(skiaContent,0-208,0-930) == css-multicol/multicol-count-non-integer-001.xht css-multicol/multicol-columns-invalid-001-ref.xht
 fuzzy(0-204,0-930) fuzzy-if(skiaContent,0-208,0-930) == css-multicol/multicol-count-non-integer-002.xht css-multicol/multicol-columns-invalid-001-ref.xht
 fuzzy(0-204,0-930) fuzzy-if(skiaContent,0-208,0-930) == css-multicol/multicol-count-non-integer-003.xht css-multicol/multicol-columns-invalid-001-ref.xht
 == css-multicol/multicol-fill-000.xht css-multicol/multicol-fill-000-ref.xht
 == css-multicol/multicol-fill-001.xht css-multicol/multicol-fill-001-ref.xht
 == css-multicol/multicol-fill-auto-001.xht css-multicol/multicol-fill-auto-001-ref.xht
 fuzzy(0-135,0-80) == css-multicol/multicol-fill-auto-002.xht css-multicol/multicol-fill-auto-002-ref.xht
 fuzzy(0-135,0-3270) == css-multicol/multicol-fill-auto-003.xht css-multicol/multicol-fill-auto-003-ref.xht
-fails == css-multicol/multicol-fill-auto-block-children-001.xht css-multicol/multicol-fill-auto-block-children-ref.xht
-fails == css-multicol/multicol-fill-auto-block-children-002.xht css-multicol/multicol-fill-auto-block-children-002-ref.xht
+pref(layout.css.column-span.enabled,true) fuzzy-if(OSX,255-255,2762-2762) == css-multicol/multicol-fill-auto-block-children-001.xht css-multicol/multicol-fill-auto-block-children-ref.xht
+pref(layout.css.column-span.enabled,true) == css-multicol/multicol-fill-auto-block-children-002.xht css-multicol/multicol-fill-auto-block-children-002-ref.xht
 fuzzy(0-135,0-80) == css-multicol/multicol-fill-balance-001.xht css-multicol/multicol-fill-balance-001-ref.xht
 skip == css-multicol/multicol-fill-balance-002.html reference/ref-filled-green-100px-square-only.html
 fuzzy(0-135,0-821) == css-multicol/multicol-gap-000.xht css-multicol/multicol-gap-000-ref.xht
 fuzzy(0-255,0-329) == css-multicol/multicol-gap-001.xht css-multicol/multicol-gap-001-ref.xht
 fuzzy(0-204,0-930) fuzzy-if(skiaContent,0-208,0-930) == css-multicol/multicol-gap-002.xht css-multicol/multicol-gap-002-ref.xht
 fuzzy(0-204,0-930) fuzzy-if(skiaContent,0-208,0-930) == css-multicol/multicol-gap-003.xht css-multicol/multicol-gap-002-ref.xht
 fuzzy(0-107,0-1823) == css-multicol/multicol-gap-fraction-001.xht css-multicol/multicol-gap-fraction-001-ref.xht
 skip == css-multicol/multicol-gap-fraction-002.html reference/nothing.html
--- a/testing/web-platform/meta/css/css-multicol/inheritance.html.ini
+++ b/testing/web-platform/meta/css/css-multicol/inheritance.html.ini
@@ -1,7 +1,2 @@
 [inheritance.html]
-  [Property column-span does not inherit]
-    expected: FAIL
-
-  [Property column-span has initial value none]
-    expected: FAIL
-
+  prefs: [layout.css.column-span.enabled:true]
--- a/testing/web-platform/meta/css/css-multicol/parsing/column-span-computed.html.ini
+++ b/testing/web-platform/meta/css/css-multicol/parsing/column-span-computed.html.ini
@@ -1,7 +1,2 @@
 [column-span-computed.html]
-  [Property column-span value 'none' computes to 'none']
-    expected: FAIL
-
-  [Property column-span value 'all' computes to 'all']
-    expected: FAIL
-
+  prefs: [layout.css.column-span.enabled:true]