Bug 1143970 - clicking on an item in the reading list sidebar now opens the item. r=gavin
authorMark Hammond <mhammond@skippinet.com.au>
Mon, 16 Mar 2015 18:25:24 -0700
changeset 233865 f60585b7803685dfb39464cc2a92be00945ff62b
parent 233864 e115937194946228db3aa064d6946c15e3bc28b0
child 233866 8beb212cceb8627a642204e5161c3eafacc6cfc9
push id28425
push usercbook@mozilla.com
push dateTue, 17 Mar 2015 10:33:06 +0000
treeherdermozilla-central@a194e8023090 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgavin
bugs1143970
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1143970 - clicking on an item in the reading list sidebar now opens the item. r=gavin
browser/components/readinglist/sidebar.js
--- a/browser/components/readinglist/sidebar.js
+++ b/browser/components/readinglist/sidebar.js
@@ -265,19 +265,17 @@ let RLSidebar = {
 
   /**
    * Open a given URL. The event is used to determine where it should be opened
    * (current tab, new tab, new window).
    * @param {string} url - URL to open.
    * @param {Event} event - KeyEvent or MouseEvent that triggered this action.
    */
   openURL(url, event) {
-    // TODO: Disabled while working on the listbox mechanics.
     log.debug(`Opening page ${url}`);
-    return;
 
     let mainWindow = window.QueryInterface(Ci.nsIInterfaceRequestor)
                            .getInterface(Ci.nsIWebNavigation)
                            .QueryInterface(Ci.nsIDocShellTreeItem)
                            .rootTreeItem
                            .QueryInterface(Ci.nsIInterfaceRequestor)
                            .getInterface(Ci.nsIDOMWindow);
     mainWindow.openUILink(url, event);