Bug 1524335: Make InOrderPacket take last_sequence_number by reference; r=dmajor
authorDan Minor <dminor@mozilla.com>
Wed, 13 Feb 2019 13:05:20 -0500
changeset 458977 f405cc68a129
parent 458976 69e057ca6ad8
child 458978 6448f6a14609
push id35553
push usershindli@mozilla.com
push dateThu, 14 Feb 2019 04:41:18 +0000
treeherdermozilla-central@f0ea53f47215 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1524335
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1524335: Make InOrderPacket take last_sequence_number by reference; r=dmajor Differential Revision: https://phabricator.services.mozilla.com/D19694
media/webrtc/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
--- a/media/webrtc/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
+++ b/media/webrtc/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
@@ -24,17 +24,17 @@
 #include "modules/rtp_rtcp/include/rtp_payload_registry.h"
 #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
 #include "modules/rtp_rtcp/source/rtp_receiver_strategy.h"
 #include "rtc_base/logging.h"
 
 namespace webrtc {
 
 namespace {
-bool InOrderPacket(rtc::Optional<uint16_t> latest_sequence_number,
+bool InOrderPacket(const rtc::Optional<uint16_t>& latest_sequence_number,
                    uint16_t current_sequence_number) {
   if (!latest_sequence_number)
     return true;
 
   // We need to distinguish between a late or retransmitted packet,
   // and a sequence number discontinuity.
   if (IsNewerSequenceNumber(current_sequence_number, *latest_sequence_number)) {
     return true;