In changeset de02d0483a7f I inadvertently added "const" to the return types of some static functions in this .cpp file. Removing that. r=me, a=me
authorBenoit Jacob <bjacob@mozilla.com>
Wed, 15 Sep 2010 22:28:12 -0400
changeset 54147 f38ef1080bfe788c6ee78c167a4e03087e5f79af
parent 54146 406cba7534451f3a3fe1aef464acfdf749a4ccc2
child 54148 38f96d215ccb44975d23d1a0015b0ee1704952ad
push id15784
push userbjacob@mozilla.com
push dateThu, 16 Sep 2010 09:29:00 +0000
treeherdermozilla-central@f38ef1080bfe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme, me
milestone2.0b7pre
first release with
nightly linux32
f38ef1080bfe / 4.0b7pre / 20100916030125 / files
nightly linux64
f38ef1080bfe / 4.0b7pre / 20100916030800 / files
nightly mac
f38ef1080bfe / 4.0b7pre / 20100916030718 / files
nightly win32
f38ef1080bfe / 4.0b7pre / 20100916041016 / files
nightly win64
f38ef1080bfe / 4.0b7pre / 20100916035518 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
In changeset de02d0483a7f I inadvertently added "const" to the return types of some static functions in this .cpp file. Removing that. r=me, a=me
widget/src/windows/GfxInfo.cpp
--- a/widget/src/windows/GfxInfo.cpp
+++ b/widget/src/windows/GfxInfo.cpp
@@ -67,17 +67,17 @@ nsresult
 GfxInfo::GetDWriteEnabled(PRBool *aEnabled)
 {
   *aEnabled = gfxWindowsPlatform::GetPlatform()->DWriteEnabled();
   return NS_OK;
 }
 
 /* XXX: GfxInfo doesn't handle multiple GPUs. We should try to do that. Bug #591057 */
 
-static const nsresult GetKeyValue(const WCHAR* keyLocation, const WCHAR* keyName, nsAString& destString, int type)
+static nsresult GetKeyValue(const WCHAR* keyLocation, const WCHAR* keyName, nsAString& destString, int type)
 {
   HKEY key;
   DWORD dwcbData;
   DWORD dValue;
   DWORD resultType;
   LONG result;
   nsresult retval = NS_OK;
 
@@ -137,17 +137,17 @@ static const nsresult GetKeyValue(const 
   RegCloseKey(key);
 
   return retval;
 }
 
 // The driver ID is a string like PCI\VEN_15AD&DEV_0405&SUBSYS_040515AD, possibly
 // followed by &REV_XXXX.  We uppercase the string, and strip the &REV_ part
 // from it, if found.
-static const void normalizeDriverId(nsString& driverid) {
+static void normalizeDriverId(nsString& driverid) {
   ToUpperCase(driverid);
   PRInt32 rev = driverid.Find(NS_LITERAL_CSTRING("&REV_"));
   if (rev != -1) {
     driverid.Cut(rev, driverid.Length());
   }
 }
 
 
@@ -521,17 +521,17 @@ static const GfxDriverInfo driverInfo[] 
 
   /*
    * AMD entries
    */
 
   { 0, 0, allDevices, 0 }
 };
 
-static const bool
+static bool
 ParseDriverVersion(nsAString& aVersion, PRUint64 *aNumericVersion)
 {
   int a, b, c, d;
   /* honestly, why do I even bother */
   if (sscanf(nsPromiseFlatCString(NS_LossyConvertUTF16toASCII(aVersion)).get(),
              "%d.%d.%d.%d", &a, &b, &c, &d) != 4)
     return false;
   if (a < 0 || a > 0xffff) return false;