Bug 1486323 - Network monitor toolbar is 1px too high. r=Honza
authorlloan <lloanalas@outlook.com>
Fri, 08 Mar 2019 11:17:15 +0000
changeset 463139 f2bd560573a4b7f684e0647d0031ce9e0b5c045a
parent 463138 4efc7fb0eae794f4708a59eea3073182080e1889
child 463140 19934e7183f7a4ea6bf10a7313f9bf091ee1c3dd
push id35668
push userbtara@mozilla.com
push dateFri, 08 Mar 2019 21:50:53 +0000
treeherdermozilla-central@14778fd00dc5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1486323
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1486323 - Network monitor toolbar is 1px too high. r=Honza For consistency with other parts of DevTools, the Network monitor toolbar (or toolbars, when splitted in 2) should be 28px high excluding borders. Currently it’s 29px, 1px taller than the toolbox's tab bar, and 1px taller than the Console’s toolbar. Differential Revision: https://phabricator.services.mozilla.com/D22430
devtools/client/netmonitor/src/assets/styles/Toolbar.css
--- a/devtools/client/netmonitor/src/assets/styles/Toolbar.css
+++ b/devtools/client/netmonitor/src/assets/styles/Toolbar.css
@@ -8,40 +8,42 @@
   display: flex;
   line-height: 23px;
 }
 
 .devtools-toolbar-container {
   height: auto;
   flex-wrap: wrap;
   justify-content: space-between;
+  border: none;
+  padding: 0;
 }
 
 .devtools-toolbar-group {
   display: flex;
   flex: 0 0 auto;
   flex-wrap: nowrap;
   align-items: center;
 }
 
 .devtools-toolbar-two-rows-1,
 .devtools-toolbar-two-rows-2,
 .devtools-toolbar-single-row {
   flex-grow: 1;
   min-height: var(--primary-toolbar-height);
   background-color: var(--theme-body-background);
+  border-bottom: 1px solid var(--theme-splitter-color);
 }
 
 .devtools-toolbar-two-rows-1 {
   width: -moz-available;
 }
 
 .devtools-toolbar-two-rows-2 {
   justify-content: space-between;
-  border-top: 1px solid var(--theme-splitter-color);
 }
 
 .requests-list-filter-buttons {
   display: flex;
   flex-wrap: wrap;
   margin: 0 7px;
 }
 
@@ -97,17 +99,17 @@
 
 .devtools-toolbar-group .devtools-filterinput {
   border: none;
   box-shadow: none;
   background-color: var(--theme-body-background);
 }
 
 .devtools-toolbar-group .devtools-searchbox {
-  height: 29px;
+  height: 28px;
   border: 1px solid transparent;
 }
 
 .devtools-toolbar-group .devtools-searchbox:focus-within {
   border: 1px solid var(--blue-50);
   margin-bottom: 0;
   margin-top: 0;
   box-shadow: none;