No bug - Add an explanatory message to the multiple-inheritance assertion in DOM bindings; rs=bz
authorMs2ger <ms2ger@gmail.com>
Fri, 13 Mar 2015 13:01:28 +0100
changeset 233532 f2a5cd37a1ecdd7c14d54da724ab4499bd0bf927
parent 233531 4100738d662d18654f30b8f1333d6f366b1781ec
child 233533 877c7d84e0c3e1ca1996685c0a8c129e5fc2f9a9
push id28417
push userryanvm@gmail.com
push dateFri, 13 Mar 2015 19:52:44 +0000
treeherdermozilla-central@977add19414a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug - Add an explanatory message to the multiple-inheritance assertion in DOM bindings; rs=bz Review was granted in <http://logs.glob.uno/?c=mozilla%23content&s=5+Dec+2013&e=5+Dec+2013#c162605>.
dom/bindings/Codegen.py
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -3201,18 +3201,19 @@ def CopyUnforgeablePropertiesToInstance(
 
 def AssertInheritanceChain(descriptor):
     asserts = ""
     iface = descriptor.interface
     while iface:
         desc = descriptor.getDescriptor(iface.identifier.name)
         asserts += (
             "MOZ_ASSERT(static_cast<%s*>(aObject) == \n"
-            "           reinterpret_cast<%s*>(aObject));\n" %
-            (desc.nativeType, desc.nativeType))
+            "           reinterpret_cast<%s*>(aObject),\n"
+            "           \"Multiple inheritance for %s is broken.\");\n" %
+            (desc.nativeType, desc.nativeType, desc.nativeType))
         iface = iface.parent
     asserts += "MOZ_ASSERT(ToSupportsIsCorrect(aObject));\n"
     return asserts
 
 
 def InitMemberSlots(descriptor, wrapperCache):
     """
     Initialize member slots on our JS object if we're supposed to have some.