Bug 917702 - Unexpected Mouse Coordinate Return when MouseEnter or MouseExit Event Fired. r=spohl
authorSteven Michaud <smichaud@pobox.com>
Mon, 30 Sep 2013 12:05:48 -0500
changeset 149355 f12083ad5943e638855d5c34d92d44205716677a
parent 149297 c707564ee0df7224e918b96a16daffc84dc92609
child 149356 41ad19b8579719af7a5887f07b842a8727ffeeef
push id25386
push useremorley@mozilla.com
push dateTue, 01 Oct 2013 09:29:22 +0000
treeherdermozilla-central@6856c45f3688 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersspohl
bugs917702
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 917702 - Unexpected Mouse Coordinate Return when MouseEnter or MouseExit Event Fired. r=spohl
widget/cocoa/nsChildView.mm
--- a/widget/cocoa/nsChildView.mm
+++ b/widget/cocoa/nsChildView.mm
@@ -6153,20 +6153,22 @@ ChildViewMouseTracker::AttachPluginEvent
   // and data.mouse.pluginY to be set to '5' for mouse-entered and mouse-exited
   // events.  But note that it's been in the tree since the Cocoa NPAPI event
   // model was first implemented four years ago, without any known complaints.
   //
   // Similar code first appeared (without explanation) in a very early version
   // ("fix 0.3") of the patch for bug 435041 ("Implement Cocoa NPAPI event
   // model for Mac OS X").  But there's no trace of it in the WebKit code that
   // was used as a model for much of that patch.
+#if (0)
   if (type == NPCocoaEventMouseEntered ||
       type == NPCocoaEventMouseExited) {
     point.x = point.y = 5;
   }
+#endif
   NSUInteger clickCount = 0;
   if (type != NPCocoaEventMouseEntered &&
       type != NPCocoaEventMouseExited &&
       type != NPCocoaEventScrollWheel) {
     clickCount = [aNativeMouseEvent clickCount];
   }
   cocoaEvent->type = type;
   cocoaEvent->data.mouse.modifierFlags = [aNativeMouseEvent modifierFlags];