Bug 1117889 - Fix hard-coded general data caption in about:telemetry. r=gfritzsche
authorGabriel Machado <gbrmachado@gmail.com>
Wed, 04 Feb 2015 16:06:48 +0000
changeset 227658 f0ff5147c6e1356c15860e72ccee47dc5babc07d
parent 227657 cab80595dfc33ec90fadda250af3a0323b92dd09
child 227659 5b82617f158dd3b608bcd876ac752c27ed7cbcdd
push id28236
push userryanvm@gmail.com
push dateThu, 05 Feb 2015 22:15:34 +0000
treeherdermozilla-central@71972672e292 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgfritzsche
bugs1117889
milestone38.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1117889 - Fix hard-coded general data caption in about:telemetry. r=gfritzsche
toolkit/content/aboutTelemetry.js
toolkit/locales/en-US/chrome/global/aboutTelemetry.properties
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -114,17 +114,18 @@ let GeneralData = {
    * Renders the general data
    */
   render: function() {
     setHasData("general-data-section", true);
 
     let table = document.createElement("table");
 
     let caption = document.createElement("caption");
-    caption.appendChild(document.createTextNode("General data\n"));
+    let captionString = bundle.GetStringFromName("generalDataTitle");
+    caption.appendChild(document.createTextNode(captionString + "\n"));
     table.appendChild(caption);
 
     let headings = document.createElement("tr");
     this.appendColumn(headings, "th", bundle.GetStringFromName("generalDataHeadingName") + "\t");
     this.appendColumn(headings, "th", bundle.GetStringFromName("generalDataHeadingValue") + "\t");
     table.appendChild(headings);
 
     let row = document.createElement("tr");
--- a/toolkit/locales/en-US/chrome/global/aboutTelemetry.properties
+++ b/toolkit/locales/en-US/chrome/global/aboutTelemetry.properties
@@ -2,16 +2,18 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 # Note to translators:
 # - %1$S will be replaced by brandFullName
 # - %2$S will be replaced with the value of the toolkit.telemetry.server_owner preference
 pageSubtitle = This page shows the information about performance, hardware, usage and customizations collected by Telemetry. This information is submitted to %1$S to help improve %2$S.
 
+generalDataTitle = General Data
+
 generalDataHeadingName = Name
 
 generalDataHeadingValue = Value
 
 slowSqlMain = Slow SQL Statements on Main Thread
 
 slowSqlOther = Slow SQL Statements on Helper Threads