author | Nicholas Cameron <ncameron@mozilla.com> |
Mon, 09 Dec 2013 14:40:59 +1300 | |
changeset 159647 | f0f2576c33402c9bfa288e6e6d35529d687be523 |
parent 159646 | c79d9a33dd43b8d14c8eb1ddbfc2c1eed8323e51 |
child 159648 | c105bff9ee1d26bfc260ab20db6405a69102128a |
push id | 25808 |
push user | cbook@mozilla.com |
push date | Tue, 10 Dec 2013 12:03:31 +0000 |
treeherder | mozilla-central@7fb91a422c5e [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | mattwoodrow |
bugs | 946958 |
milestone | 29.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
gfx/layers/composite/LayerManagerComposite.cpp | file | annotate | diff | comparison | revisions | |
gfx/layers/composite/LayerManagerComposite.h | file | annotate | diff | comparison | revisions |
--- a/gfx/layers/composite/LayerManagerComposite.cpp +++ b/gfx/layers/composite/LayerManagerComposite.cpp @@ -198,16 +198,17 @@ LayerManagerComposite::EndEmptyTransacti } void LayerManagerComposite::EndTransaction(DrawThebesLayerCallback aCallback, void* aCallbackData, EndTransactionFlags aFlags) { NS_ASSERTION(mInTransaction, "Didn't call BeginTransaction?"); + NS_ASSERTION(!aCallback && !aCallbackData, "Not expecting callbacks here"); mInTransaction = false; if (!mIsCompositorReady) { return; } mIsCompositorReady = false; #ifdef MOZ_LAYERS_HAVE_LOG @@ -235,23 +236,17 @@ LayerManagerComposite::EndTransaction(Dr // properties. mRoot->ApplyPendingUpdatesToSubtree(); } // The results of our drawing always go directly into a pixel buffer, // so we don't need to pass any global transform here. mRoot->ComputeEffectiveTransforms(gfx3DMatrix()); - mThebesLayerCallback = aCallback; - mThebesLayerCallbackData = aCallbackData; - Render(); - - mThebesLayerCallback = nullptr; - mThebesLayerCallbackData = nullptr; } mCompositor->SetTargetContext(nullptr); #ifdef MOZ_LAYERS_HAVE_LOG Log(); MOZ_LAYERS_LOG(("]----- EndTransaction")); #endif
--- a/gfx/layers/composite/LayerManagerComposite.h +++ b/gfx/layers/composite/LayerManagerComposite.h @@ -148,22 +148,16 @@ public: { MOZ_CRASH("Shouldn't be called for composited layer manager"); } virtual already_AddRefed<gfxASurface> CreateOptimalMaskSurface(const gfxIntSize &aSize) MOZ_OVERRIDE; - DrawThebesLayerCallback GetThebesLayerCallback() const - { return mThebesLayerCallback; } - - void* GetThebesLayerCallbackData() const - { return mThebesLayerCallbackData; } - virtual const char* Name() const MOZ_OVERRIDE { return ""; } enum WorldTransforPolicy { ApplyWorldTransform, DontApplyWorldTransform }; /** @@ -266,20 +260,16 @@ private: void WorldTransformRect(nsIntRect& aRect); RefPtr<Compositor> mCompositor; /** Our more efficient but less powerful alter ego, if one is available. */ nsRefPtr<Composer2D> mComposer2D; - /* Thebes layer callbacks; valid at the end of a transaciton, - * while rendering */ - DrawThebesLayerCallback mThebesLayerCallback; - void *mThebesLayerCallbackData; gfxMatrix mWorldMatrix; bool mInTransaction; bool mIsCompositorReady; nsIntRegion mInvalidRegion; nsAutoPtr<LayerProperties> mClonedLayerTreeProperties; bool mDebugOverlayWantsNextFrame; };