Bug 1613430 - Go back to LibLoadingStrategy::ReadAhead on Nightly r=glandium
authorDoug Thayer <dothayer@mozilla.com>
Thu, 06 Feb 2020 07:41:31 +0000
changeset 512768 f0cb6e48329b48f141f5c75edbcb38ba20228414
parent 512767 d9b2a47c687e437d9d0363f3f72175d1373d30ae
child 512769 caed697fb694d70f40b2d5abb7d91fd9cd56cef8
push id37097
push usercsabou@mozilla.com
push dateThu, 06 Feb 2020 21:47:20 +0000
treeherdermozilla-central@b372743705c9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1613430, 1565902
milestone74.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1613430 - Go back to LibLoadingStrategy::ReadAhead on Nightly r=glandium The original issue in bug 1565902 which prompted this investigation seems to have gone away with a Windows OS update. We saw mixed results in telemetry over this anyway, and no clear and obvious path for getting the benefits without the drawbacks, so removing this seems to be the best solution right now. Differential Revision: https://phabricator.services.mozilla.com/D61720
browser/app/nsBrowserApp.cpp
--- a/browser/app/nsBrowserApp.cpp
+++ b/browser/app/nsBrowserApp.cpp
@@ -312,25 +312,17 @@ int main(int argc, char* argv[], char* e
     return result;
   }
 #endif
 
 #ifdef HAS_DLL_BLOCKLIST
   DllBlocklist_Initialize(gBlocklistInitFlags);
 #endif
 
-  // XXX: We are testing whether removing LibLoadingStrategy::ReadAhead has a
-  // positive / neutral affect on Nightly startup measures. If it does, we will
-  // rip out the enum and corresponding arguments. See bug 1565902.
-#ifdef NIGHTLY_BUILD
-  nsresult rv = InitXPCOMGlue(LibLoadingStrategy::NoReadAhead);
-#else
   nsresult rv = InitXPCOMGlue(LibLoadingStrategy::ReadAhead);
-#endif
-
   if (NS_FAILED(rv)) {
     return 255;
   }
 
   gBootstrap->XRE_StartupTimelineRecord(mozilla::StartupTimeline::START, start);
 
 #ifdef MOZ_BROWSER_CAN_BE_CONTENTPROC
   gBootstrap->XRE_EnableSameExecutableForContentProc();