Back out half of the previous patch for bug 709747, since the nsCOMPtr<nsISupports>::forget(nsISupports**) specialization is substantially different from nsCOMPtr<T>::forget(I**), and uses swap which already does the needed logging.
authorL. David Baron <dbaron@dbaron.org>
Fri, 29 Jun 2012 22:50:45 -0700
changeset 97931 f08d285b63b0f9c8d30152dad07875725753d9c9
parent 97930 eb59a7e6d1010d49a2e5ae90185f0f14f4707457
child 97932 46362775ce798845417e047b1c52958fe67cf0d4
child 98697 ea8c4810d3d5a5a2d60452143024ded37bc318fa
push id23015
push userdbaron@mozilla.com
push dateSat, 30 Jun 2012 05:51:18 +0000
treeherdermozilla-central@f08d285b63b0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs709747
milestone16.0a1
first release with
nightly linux32
f08d285b63b0 / 16.0a1 / 20120630030532 / files
nightly linux64
f08d285b63b0 / 16.0a1 / 20120630030532 / files
nightly mac
f08d285b63b0 / 16.0a1 / 20120630030532 / files
nightly win32
f08d285b63b0 / 16.0a1 / 20120630030532 / files
nightly win64
f08d285b63b0 / 16.0a1 / 20120630030532 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Back out half of the previous patch for bug 709747, since the nsCOMPtr<nsISupports>::forget(nsISupports**) specialization is substantially different from nsCOMPtr<T>::forget(I**), and uses swap which already does the needed logging.
xpcom/glue/nsCOMPtr.h
--- a/xpcom/glue/nsCOMPtr.h
+++ b/xpcom/glue/nsCOMPtr.h
@@ -1042,17 +1042,16 @@ class nsCOMPtr<nsISupports>
 
       void
       forget( nsISupports** rhs NS_OUTPARAM )
           // Set the target of rhs to the value of mRawPtr and null out mRawPtr.
           // Useful to avoid unnecessary AddRef/Release pairs with "out"
           // parameters.
         {
           NS_ASSERTION(rhs, "Null pointer passed to forget!");
-          NSCAP_LOG_RELEASE(this, mRawPtr);
           *rhs = 0;
           swap(*rhs);
         }
 
         // Other pointer operators
 
       nsISupports*
       get() const