Bug 1465060 - Part 2: Don't suppress pessimizing-move and self-move warnings r=froydnj
authorMiko Mynttinen <mikokm@gmail.com>
Fri, 01 Jun 2018 14:09:30 +0200
changeset 421128 f02640343be7b12a1a18cc9fd688056b93b4c2fe
parent 421127 a0d11b55d5957a488b41420c4f6cc178df7cd2e7
child 421129 eb122eb10aad7702541251873ccfc74c5c405d2f
push id34088
push userdluca@mozilla.com
push dateMon, 04 Jun 2018 17:56:32 +0000
treeherdermozilla-central@5b15326286d4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1465060
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1465060 - Part 2: Don't suppress pessimizing-move and self-move warnings r=froydnj MozReview-Commit-ID: KtQ31q6uFqZ
build/moz.configure/warnings.configure
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -81,22 +81,16 @@ check_and_add_gcc_warning('-Wstring-conv
 
 # we inline 'new' and 'delete' in mozalloc
 check_and_add_gcc_warning('-Wno-inline-new-delete', cxx_compiler)
 
 # Prevent the following GCC warnings from being treated as errors:
 # too many false positives
 check_and_add_gcc_warning('-Wno-error=maybe-uninitialized')
 
-# Turned on by -Wall, but needs changes to be turned into an error
-# (bug 1465060).
-check_and_add_gcc_warning('-Wno-error=pessimizing-move')
-# This one is probably easier, it's only triggered by tests.
-check_and_add_gcc_warning('-Wno-error=self-move')
-
 # we don't want our builds held hostage when a platform-specific API
 # becomes deprecated.
 check_and_add_gcc_warning('-Wno-error=deprecated-declarations')
 
 # false positives depending on optimization
 check_and_add_gcc_warning('-Wno-error=array-bounds')
 
 # can't get rid of those PGO warnings