author | Boris Zbarsky <bzbarsky@mit.edu> |
Tue, 11 Jul 2017 17:49:24 -0400 | |
changeset 368371 | efa1a50149e54b00f13e5c5818a92faacd0ea1bf |
parent 368370 | 1fcc2c629f1be51d4746a9a881c5ff83b0315890 |
child 368372 | e3bb0b805eca79dce9c66f6d28cf69eecb87075f |
push id | 32162 |
push user | cbook@mozilla.com |
push date | Wed, 12 Jul 2017 09:07:26 +0000 |
treeherder | mozilla-central@09a4282d1172 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | smaug |
bugs | 1379728 |
milestone | 56.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
dom/events/EventNameList.h | file | annotate | diff | comparison | revisions | |
xpfe/appshell/nsWebShellWindow.cpp | file | annotate | diff | comparison | revisions |
--- a/dom/events/EventNameList.h +++ b/dom/events/EventNameList.h @@ -177,17 +177,17 @@ EVENT(auxclick, EventNameType_All, eMouseEventClass) EVENT(click, eMouseClick, EventNameType_All, eMouseEventClass) EVENT(close, eClose, - EventNameType_HTML, + EventNameType_HTMLXUL, eBasicEventClass) EVENT(contextmenu, eContextMenu, EventNameType_HTMLXUL, eMouseEventClass) NON_IDL_EVENT(mouselongtap, eMouseLongTap, EventNameType_HTMLXUL, @@ -779,20 +779,16 @@ NON_IDL_EVENT(compositionupdate, NON_IDL_EVENT(compositionend, eCompositionEnd, EventNameType_XUL, eCompositionEventClass) NON_IDL_EVENT(command, eXULCommand, EventNameType_XUL, eInputEventClass) -NON_IDL_EVENT(close, - eWindowClose, - EventNameType_XUL, - eBasicEventClass) NON_IDL_EVENT(popupshowing, eXULPopupShowing, EventNameType_XUL, eBasicEventClass) NON_IDL_EVENT(popupshown, eXULPopupShown, EventNameType_XUL, eBasicEventClass)
--- a/xpfe/appshell/nsWebShellWindow.cpp +++ b/xpfe/appshell/nsWebShellWindow.cpp @@ -326,17 +326,17 @@ nsWebShellWindow::RequestWindowClose(nsI if (!presShell) { mozilla::DebugOnly<bool> dying; MOZ_ASSERT(NS_SUCCEEDED(mDocShell->IsBeingDestroyed(&dying)) && dying, "No presShell, but window is not being destroyed"); } else if (eventTarget) { RefPtr<nsPresContext> presContext = presShell->GetPresContext(); nsEventStatus status = nsEventStatus_eIgnore; - WidgetMouseEvent event(true, eWindowClose, nullptr, + WidgetMouseEvent event(true, eClose, nullptr, WidgetMouseEvent::eReal); if (NS_SUCCEEDED(eventTarget->DispatchDOMEvent(&event, nullptr, presContext, &status)) && status == nsEventStatus_eConsumeNoDefault) return false; } Destroy(); return false; @@ -698,17 +698,17 @@ bool nsWebShellWindow::ExecuteCloseHandl if (eventTarget) { nsCOMPtr<nsIContentViewer> contentViewer; mDocShell->GetContentViewer(getter_AddRefs(contentViewer)); if (contentViewer) { RefPtr<nsPresContext> presContext; contentViewer->GetPresContext(getter_AddRefs(presContext)); nsEventStatus status = nsEventStatus_eIgnore; - WidgetMouseEvent event(true, eWindowClose, nullptr, + WidgetMouseEvent event(true, eClose, nullptr, WidgetMouseEvent::eReal); nsresult rv = eventTarget->DispatchDOMEvent(&event, nullptr, presContext, &status); if (NS_SUCCEEDED(rv) && status == nsEventStatus_eConsumeNoDefault) return true; // else fall through and return false }