Bug 1461635 - Enforce a minimum widget size of 1x1 for toolbar separators. r=spohl
authorMarkus Stange <mstange@themasta.com>
Wed, 23 May 2018 11:55:41 -0400
changeset 419594 eedb9180bc3b62eb39e6b1221a355282d1b40149
parent 419560 366a9f1b95f689bebddef872b616235e7f299ba8
child 419595 02159d1ec622088538ee4a5d1d9af5043e8c787f
push id34040
push userebalazs@mozilla.com
push dateThu, 24 May 2018 09:37:05 +0000
treeherdermozilla-central@c411ccb6bb4a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersspohl
bugs1461635
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1461635 - Enforce a minimum widget size of 1x1 for toolbar separators. r=spohl MozReview-Commit-ID: Gc5TC5DGUI
widget/cocoa/nsNativeThemeCocoa.mm
--- a/widget/cocoa/nsNativeThemeCocoa.mm
+++ b/widget/cocoa/nsNativeThemeCocoa.mm
@@ -4094,16 +4094,22 @@ nsNativeThemeCocoa::GetMinimumWidgetSize
     case NS_THEME_PROGRESSBAR:
     {
       SInt32 barHeight = 0;
       ::GetThemeMetric(kThemeMetricNormalProgressBarThickness, &barHeight);
       aResult->SizeTo(0, barHeight);
       break;
     }
 
+    case NS_THEME_SEPARATOR:
+    {
+      aResult->SizeTo(1, 1);
+      break;
+    }
+
     case NS_THEME_TREETWISTY:
     case NS_THEME_TREETWISTYOPEN:
     {
       SInt32 twistyHeight = 0, twistyWidth = 0;
       ::GetThemeMetric(kThemeMetricDisclosureButtonWidth, &twistyWidth);
       ::GetThemeMetric(kThemeMetricDisclosureButtonHeight, &twistyHeight);
       aResult->SizeTo(twistyWidth, twistyHeight);
       *aIsOverridable = false;