Bug 1417442 - P3. Don't enable nv12 surfaces if we failed to parse the version string. r=mattwoodrow
authorJean-Yves Avenard <jyavenard@mozilla.com>
Wed, 15 Nov 2017 23:33:37 +0100
changeset 392392 eeb2f534cf10
parent 392391 f1ce735006d8
child 392393 be47971d367a
push id32920
push usernerli@mozilla.com
push dateFri, 17 Nov 2017 22:01:05 +0000
treeherdermozilla-central@7ef46e350289 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1417442
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1417442 - P3. Don't enable nv12 surfaces if we failed to parse the version string. r=mattwoodrow MozReview-Commit-ID: 1MKtCOO1gcS
dom/media/platforms/wmf/DXVA2Manager.cpp
--- a/dom/media/platforms/wmf/DXVA2Manager.cpp
+++ b/dom/media/platforms/wmf/DXVA2Manager.cpp
@@ -1260,17 +1260,17 @@ DXVA2Manager::IsNV12Supported(uint32_t a
     for (const auto& model : sAMDPreUVD4) {
       if (aDeviceID == model) {
         return false;
       }
     }
     // AMD driver earlier than 21.19.411.0 have bugs in their handling of NV12
     // surfaces.
     uint64_t driverVersion;
-    if (widget::ParseDriverVersion(aDriverVersionString, &driverVersion) &&
+    if (!widget::ParseDriverVersion(aDriverVersionString, &driverVersion) ||
         driverVersion < widget::V(21, 19, 411, 0)) {
       return false;
     }
   } else if (aVendorID == 0x10DE) {
     // NVidia
     for (const auto& model : sNVIDIABrokenNV12) {
       if (aDeviceID == model) {
         return false;