Bug 1529339: Enable signing for win64-aarch64 builds, for xpcshell tests; r=Callek
authorTom Prince <mozilla@hocat.ca>
Thu, 21 Feb 2019 13:15:12 +0000
changeset 460279 ee5fa9cfca438adf1387efed0f7c39e646d6a21f
parent 460278 78d3e59ea9fae27455ea29b4d19ef108629aa31d
child 460280 6982b26698b4ab8b29e07367248de61b07a66c87
push id35590
push userrgurzau@mozilla.com
push dateFri, 22 Feb 2019 05:26:22 +0000
treeherdermozilla-central@cd28688c1642 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersCallek
bugs1529339
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1529339: Enable signing for win64-aarch64 builds, for xpcshell tests; r=Callek Differential Revision: https://phabricator.services.mozilla.com/D20543
taskcluster/ci/test/xpcshell.yml
taskcluster/taskgraph/loader/build_signing.py
--- a/taskcluster/ci/test/xpcshell.yml
+++ b/taskcluster/ci/test/xpcshell.yml
@@ -18,17 +18,16 @@ job-defaults:
                     - remove_executables.py
                 macosx.*:
                     - unittests/mac_unittest.py
                 windows.*:
                     - unittests/win_taskcluster_unittest.py
         requires-signed-builds:
             by-test-platform:
                 windows10-64-asan/opt: false    # No XPCShell on ASAN yet
-                windows10-aarch64/*: false    # No signing on arm64
                 windows.*: true
                 default: false
 
 xpcshell:
     description: "xpcshell test run"
     suite: xpcshell
     treeherder-symbol: X(X)
     run-on-projects:
--- a/taskcluster/taskgraph/loader/build_signing.py
+++ b/taskcluster/taskgraph/loader/build_signing.py
@@ -6,16 +6,17 @@ from __future__ import absolute_import, 
 
 from taskgraph.loader.single_dep import loader as base_loader
 
 # XXX: This logic should rely in kind.yml. This hasn't been done in the original
 # patch because it required some heavy changes in single_dep.
 NON_NIGHTLY_LABELS_WHICH_SHOULD_SIGN_BUILDS = (
     'build-win32/debug', 'build-win32/opt', 'build-win32/pgo',
     'build-win64/debug', 'build-win64/opt', 'build-win64/pgo',
+    'build-win64-aarch64/opt', 'build-win64-aarch64/debug'
     'build-win32-devedition/opt', 'build-win64-devedition/opt',
     'build-win64-ccov/debug',
     'build-linux/opt', 'build-linux64/opt', 'build-linux64/pgo',
     'build-macosx64/opt',
     'build-android-api-16/opt'
     'release-source-linux64-source/opt',
     'release-source-linux64-fennec-source/opt',
     'release-source-linux64-devedition-source/opt',