Bug 1626539 - Remove the dlgType property from XUL buttons. r=bgrins
authorDão Gottwald <dao@mozilla.com>
Wed, 01 Apr 2020 15:08:08 +0000
changeset 521615 ee4305ec81fbe5dd5dbe3ecb3993433c52681c14
parent 521614 d8ae3a47afb57e7696523adc0d7545724a401abe
child 521616 46eb82332500cb8fda49f699b4a92d65f3e50e28
push id37272
push usercsabou@mozilla.com
push dateWed, 01 Apr 2020 21:26:59 +0000
treeherdermozilla-central@011ad9ff2608 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins
bugs1626539
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1626539 - Remove the dlgType property from XUL buttons. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D69162
dom/interfaces/xul/nsIDOMXULButtonElement.idl
toolkit/content/tests/chrome/test_dialogfocus.xhtml
toolkit/content/widgets/button.js
--- a/dom/interfaces/xul/nsIDOMXULButtonElement.idl
+++ b/dom/interfaces/xul/nsIDOMXULButtonElement.idl
@@ -3,17 +3,16 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "nsIDOMXULControlElement.idl"
 
 [scriptable, uuid(6ed53cfb-9e59-424c-af8d-e74582381951)]
 interface nsIDOMXULButtonElement : nsIDOMXULControlElement {
   attribute AString type;
-  attribute AString dlgType;
 
   // For buttons of type="menu" only.
   attribute boolean open;
 
   // For buttons of type="checkbox" only.
   attribute boolean checked;
 
   // For buttons of type="radio" only.
--- a/toolkit/content/tests/chrome/test_dialogfocus.xhtml
+++ b/toolkit/content/tests/chrome/test_dialogfocus.xhtml
@@ -78,17 +78,17 @@ function runTest()
     // if full keyboard access is not on, just skip the tests
     if (fullKeyboardAccess) {
       if (!(event.target instanceof Element)) {
         info("target not an Element");
         return;
       }
 
       if (expectedFocus[0] == "_")
-        match = (activeElement.dlgType == expectedFocus.substring(1));
+        match = (activeElement.getAttribute("dlgtype") == expectedFocus.substring(1));
       else
         match = (activeElement.id == expectedFocus);
       info("match = " + match);
       if (!match)
         return;
     }
     else {
       match = (activeElement == win.document.documentElement);
--- a/toolkit/content/widgets/button.js
+++ b/toolkit/content/widgets/button.js
@@ -130,25 +130,16 @@
       }
       return val;
     }
 
     get disabled() {
       return this.getAttribute("disabled") == "true";
     }
 
-    set dlgType(val) {
-      this.setAttribute("dlgtype", val);
-      return val;
-    }
-
-    get dlgType() {
-      return this.getAttribute("dlgtype");
-    }
-
     set group(val) {
       this.setAttribute("group", val);
       return val;
     }
 
     get group() {
       return this.getAttribute("group");
     }