Bug 1570840 - Set com.apple.security.cs.disable-library-validation=false in Hardened Runtime entitlement files r=handyman
☠☠ backed out by aab73dbec458 ☠ ☠
authorHaik Aftandilian <haftandilian@mozilla.com>
Wed, 14 Aug 2019 19:42:19 +0000
changeset 488032 ee3e55708782cc1d6d3965a01fbbb3f704f3fc18
parent 488031 c02aa182735b12c584d7e9eff3a366d6e28c73e3
child 488033 b8dc5c55123513799253116f3afdb67e52992ec9
push id36434
push usercbrindusan@mozilla.com
push dateThu, 15 Aug 2019 09:44:30 +0000
treeherdermozilla-central@144fbfb409b7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershandyman
bugs1570840
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1570840 - Set com.apple.security.cs.disable-library-validation=false in Hardened Runtime entitlement files r=handyman Set com.apple.security.cs.disable-library-validation=false in developer and production Hardened Runtime entitlements now that the definition has changed to mean allow/disallow unsigned libraries. Differential Revision: https://phabricator.services.mozilla.com/D40525
security/mac/hardenedruntime/developer.entitlements.xml
security/mac/hardenedruntime/production.entitlements.xml
--- a/security/mac/hardenedruntime/developer.entitlements.xml
+++ b/security/mac/hardenedruntime/developer.entitlements.xml
@@ -18,22 +18,21 @@
     <key>com.apple.security.cs.allow-jit</key><false/>
 
     <!-- Firefox needs to create executable pages (without MAP_JIT) -->
     <key>com.apple.security.cs.allow-unsigned-executable-memory</key><true/>
 
     <!-- Code paged in from disk should match the signature at page-in time -->
     <key>com.apple.security.cs.disable-executable-page-protection</key><false/>
 
-    <!-- Allow loading third party libraries. Needed for Flash and CDMs -->
-    <key>com.apple.security.cs.disable-library-validation</key><true/>
+    <!-- Do not allow loading unsigned libraries -->
+    <key>com.apple.security.cs.disable-library-validation</key><false/>
 
     <!-- Allow dyld environment variables. Needed because Firefox uses
-         dyld variables (such as @executable_path) to load libaries from
-         within the .app bundle. -->
+         dyld variables to load libaries from within the .app bundle. -->
     <key>com.apple.security.cs.allow-dyld-environment-variables</key><true/>
 
     <!-- Allow debuggers to attach to running executables -->
     <key>com.apple.security.get-task-allow</key><true/>
 
     <!-- Firefox needs to access the microphone on sites the user allows -->
     <key>com.apple.security.device.audio-input</key><true/>
 
--- a/security/mac/hardenedruntime/production.entitlements.xml
+++ b/security/mac/hardenedruntime/production.entitlements.xml
@@ -15,22 +15,21 @@
     <key>com.apple.security.cs.allow-jit</key><false/>
 
     <!-- Firefox needs to create executable pages (without MAP_JIT) -->
     <key>com.apple.security.cs.allow-unsigned-executable-memory</key><true/>
 
     <!-- Code paged in from disk should match the signature at page in-time -->
     <key>com.apple.security.cs.disable-executable-page-protection</key><false/>
 
-    <!-- Allow loading third party libraries. Needed for Flash and CDMs -->
-    <key>com.apple.security.cs.disable-library-validation</key><true/>
+    <!-- Do not allow loading unsigned libraries -->
+    <key>com.apple.security.cs.disable-library-validation</key><false/>
 
     <!-- Allow dyld environment variables. Needed because Firefox uses
-         dyld variables (such as @executable_path) to load libaries from
-         within the .app bundle. -->
+         dyld variables to load libaries from within the .app bundle. -->
     <key>com.apple.security.cs.allow-dyld-environment-variables</key><true/>
 
     <!-- Don't allow debugging of the executable. Debuggers will be prevented
          from attaching to running executables. Notarization does not permit
          access to get-task-allow (as documented by Apple) so this must be
          disabled on notarized builds. -->
     <key>com.apple.security.get-task-allow</key><false/>