Backed out changeset 75634ae8f7c5 (bug 1537657) for causing debugger failures CLOSED TREE
authorarthur.iakab <aiakab@mozilla.com>
Sat, 23 Mar 2019 01:28:27 +0200
changeset 465786 ed5dca04ca54811c2208c708b3c02e9d2cb10f4e
parent 465785 ca22160618275d1db3d12539a89609a8d7695909
child 465787 b255e2562c9648616121ba7a167449430452895b
push id35746
push usershindli@mozilla.com
push dateSat, 23 Mar 2019 09:46:24 +0000
treeherdermozilla-central@02b7484f316b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1537657
milestone68.0a1
backs out75634ae8f7c53f39474e2dc40a247006254945bc
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 75634ae8f7c5 (bug 1537657) for causing debugger failures CLOSED TREE
devtools/client/debugger/new/src/actions/navigation.js
devtools/client/debugger/new/src/client/firefox/commands.js
--- a/devtools/client/debugger/new/src/actions/navigation.js
+++ b/devtools/client/debugger/new/src/actions/navigation.js
@@ -36,17 +36,16 @@ export function willNavigate(event: Obje
   return function({ dispatch, getState, client, sourceMaps }: ThunkArgs) {
     sourceMaps.clearSourceMaps();
     clearWasmStates();
     clearDocuments();
     clearSymbols();
     clearASTs();
     clearScopes();
     clearSources();
-    client.detachWorkers();
     dispatch(navigate(event.url));
   };
 }
 
 export function navigate(url: string) {
   return async function({ dispatch, getState }: ThunkArgs) {
     sourceQueue.clear();
     const thread = getMainThread(getState());
--- a/devtools/client/debugger/new/src/client/firefox/commands.js
+++ b/devtools/client/debugger/new/src/client/firefox/commands.js
@@ -182,22 +182,16 @@ function locationKey(location: Breakpoin
   const sourceId = location.sourceId || "";
   return `${(sourceUrl: any)}:${sourceId}:${line}:${(column: any)}`;
 }
 
 function waitForWorkers(shouldWait: boolean) {
   shouldWaitForWorkers = shouldWait;
 }
 
-function detachWorkers() {
-  for (const thread of listWorkerThreadClients()) {
-    thread.detach();
-  }
-}
-
 function maybeGenerateLogGroupId(options) {
   if (options.logValue && tabTarget.traits && tabTarget.traits.canRewind) {
     return { ...options, logGroupId: `logGroup-${Math.random()}` };
   }
   return options;
 }
 
 function maybeClearLogpoint(location: BreakpointLocation) {
@@ -486,13 +480,12 @@ const clientCommands = {
   pauseOnExceptions,
   fetchSources,
   registerSourceActor,
   fetchWorkers,
   getMainThread,
   sendPacket,
   setSkipPausing,
   setEventListenerBreakpoints,
-  waitForWorkers,
-  detachWorkers
+  waitForWorkers
 };
 
 export { setupCommands, clientCommands };