Bug 1336559 - Rename source-check kind to source-test, r=dustin
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Thu, 02 Feb 2017 16:16:06 -0500
changeset 344750 ed46199e1f44717991b90f82461e3d3f4c25c1dd
parent 344749 30fd632d64eb0d84e4a4ebee244e9a6f4aa66e4f
child 344751 23fbbffc07270141b7069876e62f0d4f88c00095
push id31416
push userkwierso@gmail.com
push dateSat, 25 Feb 2017 00:41:26 +0000
treeherdermozilla-central@c3ea1dcedccd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdustin
bugs1336559
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1336559 - Rename source-check kind to source-test, r=dustin The name 'source-check' is a bit of a misnomer, because it already includes a bunch of tasks that are proper unittests, not lints. Some of these unittests will soon depend on a build task, which makes 'source-check' feel even more wrong. They still have a lot in common with the lint tasks though, so it's probably not worth splitting this into two separate kinds. Instead, let's just rename this kind to 'source-test', which means, any task that tests stuff and is run from the source directory (instead of a tests.zip). I think both lints and python-tests fall squarely under this definition. MozReview-Commit-ID: K0gZ5rVLyeD
taskcluster/ci/source-check/doc.yml
taskcluster/ci/source-check/kind.yml
taskcluster/ci/source-check/mozlint.yml
taskcluster/ci/source-check/python-tests.yml
taskcluster/ci/source-check/webidl.yml
taskcluster/ci/source-test/doc.yml
taskcluster/ci/source-test/kind.yml
taskcluster/ci/source-test/mozlint.yml
taskcluster/ci/source-test/python-tests.yml
taskcluster/ci/source-test/webidl.yml
taskcluster/docs/kinds.rst
taskcluster/taskgraph/try_option_syntax.py
rename from taskcluster/ci/source-check/doc.yml
rename to taskcluster/ci/source-test/doc.yml
rename from taskcluster/ci/source-check/kind.yml
rename to taskcluster/ci/source-test/kind.yml
rename from taskcluster/ci/source-check/mozlint.yml
rename to taskcluster/ci/source-test/mozlint.yml
rename from taskcluster/ci/source-check/python-tests.yml
rename to taskcluster/ci/source-test/python-tests.yml
rename from taskcluster/ci/source-check/webidl.yml
rename to taskcluster/ci/source-test/webidl.yml
--- a/taskcluster/docs/kinds.rst
+++ b/taskcluster/docs/kinds.rst
@@ -45,23 +45,23 @@ in order to provide localized versions o
 nightly-l10n-signing
 --------------------
 
 The nightly l10n signing kind takes artifacts from the nightly-l10n kind and
 passes them to signing servers to have their contents signed appropriately, based
 on an appropriate signing format. One signing job is created for each nightly-l10n
 job (usually chunked).
 
-source-check
+source-test
 ------------
 
-Source-checks are tasks that look at the Gecko source directly to check
-correctness.  This can include linting, Python unit tests, source-code
-analysis, or measurement work -- basically anything that does not require a
-build.
+Source-tests are tasks that run directly from the Gecko source. This can include linting,
+unit tests, source-code analysis, or measurement work. While source-test tasks run from
+a source checkout, it is still possible for them to depend on a build artifact, though
+often they do not.
 
 upload-symbols
 --------------
 
 Upload-symbols tasks run after builds and upload the symbols files generated by
 build tasks to Socorro for later use in crash analysis.
 
 valgrind
--- a/taskcluster/taskgraph/try_option_syntax.py
+++ b/taskcluster/taskgraph/try_option_syntax.py
@@ -30,17 +30,17 @@ BUILD_KINDS = set([
     'upload-symbols',
     'valgrind',
     'static-analysis',
     'spidermonkey',
 ])
 
 # anything in this list is governed by -j
 JOB_KINDS = set([
-    'source-check',
+    'source-test',
     'toolchain',
     'marionette-harness',
     'android-stuff',
 ])
 
 
 # mapping from shortcut name (usable with -u) to a boolean function identifying
 # matching test names