Bug 1459985 - Include stringbundle Custom Element registration inside profile manager;r=mossop
authorBrian Grinstead <bgrinstead@mozilla.com>
Tue, 08 May 2018 09:52:06 -0700
changeset 417349 ecbcf736a436b73d67e03b4a8eafe490f9ea7018
parent 417348 3c5ec0ff49dc7239a6e72d311e04b047ad6d50fc
child 417472 0cd106a2eb78aa04fd481785257e6f4f9b94707b
child 417473 9135bdd314c2467be6e56157f6598d39bbdff4e3
push id33966
push useraciure@mozilla.com
push dateTue, 08 May 2018 22:55:45 +0000
treeherdermozilla-central@ecbcf736a436 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmossop
bugs1459985
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1459985 - Include stringbundle Custom Element registration inside profile manager;r=mossop Currently stringbundle.js is loaded in response to the document-element-inserted message in MainProcessSingleton. But since the profile manager loads before that script is run, we don't register the Custom Element. This fixes that by explicitly including the script. MozReview-Commit-ID: GqQk1VUv0Df
toolkit/profile/content/createProfileWizard.xul
toolkit/profile/content/profileSelection.xul
--- a/toolkit/profile/content/createProfileWizard.xul
+++ b/toolkit/profile/content/createProfileWizard.xul
@@ -15,17 +15,19 @@
 <wizard id="createProfileWizard"
         title="&newprofile.title;"
         xmlns:html="http://www.w3.org/1999/xhtml"
         xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
         onwizardfinish="return onFinish();"
         onload="initWizard();"
         style="&window.size;">
-  
+  <script type="application/javascript"
+          src="chrome://global/content/elements/stringbundle.js"/>
+
   <stringbundle id="bundle_profileManager"
                 src="chrome://mozapps/locale/profile/profileSelection.properties"/>
 
   <script type="application/javascript" src="chrome://mozapps/content/profile/createProfileWizard.js"/>
 
   <wizardpage id="explanation" onpageshow="enableNextButton();">
     <description>&profileCreationExplanation_1.text;</description>
     <description>&profileCreationExplanation_2.text;</description>
--- a/toolkit/profile/content/profileSelection.xul
+++ b/toolkit/profile/content/profileSelection.xul
@@ -24,16 +24,19 @@
   buttons="accept,cancel"
   style="width: 30em;"
   onload="startup();"
   ondialogaccept="return acceptDialog()"
   ondialogcancel="return exitDialog()"
   buttonlabelaccept="&start.label;"
   buttonlabelcancel="&exit.label;">
 
+  <script type="application/javascript"
+          src="chrome://global/content/elements/stringbundle.js"/>
+
   <stringbundle id="bundle_profileManager"
                 src="chrome://mozapps/locale/profile/profileSelection.properties"/>
   <stringbundle id="bundle_brand"
                 src="chrome://branding/locale/brand.properties"/>
 
   <script type="application/javascript" src="chrome://mozapps/content/profile/profileSelection.js"/>
 
   <description class="label">&pmDescription.label;</description>