Bug 1490218 - Disable sccache on PGO builds r=dmajor
authorMike Hommey <mh+mozilla@glandium.org>
Tue, 11 Sep 2018 22:44:09 +0000
changeset 435817 ec76e671d3da837bfabba43660343576fda8f90d
parent 435816 283bfe626f5b8fca586425a55124c6324b005d9d
child 435818 23860890d959f318130e619976cbeae4472937a3
push id34619
push userbtara@mozilla.com
push dateWed, 12 Sep 2018 03:11:51 +0000
treeherdermozilla-central@23860890d959 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1490218, 1476604, 1484897
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1490218 - Disable sccache on PGO builds r=dmajor Currently, sccache doesn't work at all with clang-cl (PGO or not, bug 1476604), and newer versions of sccache that do the right thing for PGO flags with clang have other problems (see bug 1484897). The benefit of sccache on PGO+LTO builds is however limited (the profile-use half of the build doesn't benefit at all, and since it does LTO as well, it's the most time-consuming part of the build), so in order not to further block switching Linux builds to clang, let's just disable sccache on PGO builds for now (the earlier we can switch to clang, the more time it leaves to catch any problem that causes). Differential Revision: https://phabricator.services.mozilla.com/D5509
build/mozconfig.cache
--- a/build/mozconfig.cache
+++ b/build/mozconfig.cache
@@ -1,16 +1,16 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 # Setup for build cache
 
 # builds where buildprops didn't have the data (eg: taskcluster) and without sccache disabled:
-if test -z "$bucket" -a -z "$SCCACHE_DISABLE"; then
+if test -z "$bucket" -a -z "$SCCACHE_DISABLE" -a -z "$MOZ_PGO"; then
 
     # prevent rerun if az is set, or wget is not available
     if test -z "$availability_zone" -a -x "$(command -v wget)"; then
         if test -n "${TASKCLUSTER_WORKER_GROUP}"; then
             # TASKCLUSTER_WORKER_GROUP is just the region now, so
             # stick an extra character on to make the already-convoluted logic
             # here simpler.
             availability_zone="${TASKCLUSTER_WORKER_GROUP}x"