Bug 1438611: Remove unused mDirty property from nsToolkitProfileService. r=florian
authorDave Townsend <dtownsend@oxymoronical.com>
Wed, 08 Nov 2017 09:15:50 -0800
changeset 404535 ec2261548c49fe1d9cda4b19898f50b9a771d23c
parent 404534 b4a269445e958d9c4deab2b028ccb9bfa80ee70e
child 404536 9e096038bd581718463c892ded095ba08c496b73
push id33482
push userrgurzau@mozilla.com
push dateWed, 21 Feb 2018 10:00:30 +0000
treeherdermozilla-central@bb0271610fd8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersflorian
bugs1438611
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1438611: Remove unused mDirty property from nsToolkitProfileService. r=florian MozReview-Commit-ID: 4bTVuO49FaC
toolkit/profile/nsToolkitProfileService.cpp
--- a/toolkit/profile/nsToolkitProfileService.cpp
+++ b/toolkit/profile/nsToolkitProfileService.cpp
@@ -116,17 +116,16 @@ public:
     NS_DECL_NSITOOLKITPROFILESERVICE
 
 private:
     friend class nsToolkitProfile;
     friend class nsToolkitProfileFactory;
     friend nsresult NS_NewToolkitProfileService(nsIToolkitProfileService**);
 
     nsToolkitProfileService() :
-        mDirty(false),
         mStartWithLast(true),
         mStartOffline(false)
     {
         gService = this;
     }
     ~nsToolkitProfileService()
     {
         gService = nullptr;
@@ -145,17 +144,16 @@ private:
                                    nsIToolkitProfile** aResult);
 
     RefPtr<nsToolkitProfile>  mFirst;
     nsCOMPtr<nsIToolkitProfile> mChosen;
     nsCOMPtr<nsIToolkitProfile> mDefault;
     nsCOMPtr<nsIFile>           mAppData;
     nsCOMPtr<nsIFile>           mTempData;
     nsCOMPtr<nsIFile>           mListFile;
-    bool mDirty;
     bool mStartWithLast;
     bool mStartOffline;
 
     static nsToolkitProfileService *gService;
 
     class ProfileEnumerator final : public nsISimpleEnumerator
     {
     public:
@@ -219,17 +217,16 @@ nsToolkitProfile::GetName(nsACString& aR
 NS_IMETHODIMP
 nsToolkitProfile::SetName(const nsACString& aName)
 {
     NS_ASSERTION(nsToolkitProfileService::gService,
                  "Where did my service go?");
     NS_ENSURE_TRUE(!mForExternalApp, NS_ERROR_NOT_IMPLEMENTED);
 
     mName = aName;
-    nsToolkitProfileService::gService->mDirty = true;
 
     return NS_OK;
 }
 
 nsresult
 nsToolkitProfile::RemoveInternal(bool aRemoveFiles, bool aInBackground)
 {
     NS_ASSERTION(nsToolkitProfileService::gService,
@@ -280,18 +277,16 @@ nsToolkitProfile::RemoveInternal(bool aR
         mNext->mPrev = mPrev;
 
     mPrev = nullptr;
     mNext = nullptr;
 
     if (nsToolkitProfileService::gService->mChosen == this)
         nsToolkitProfileService::gService->mChosen = nullptr;
 
-    nsToolkitProfileService::gService->mDirty = true;
-
     return NS_OK;
 }
 
 NS_IMETHODIMP
 nsToolkitProfile::Remove(bool removeFiles)
 {
     return RemoveInternal(removeFiles, false /* in background */);
 }
@@ -567,17 +562,16 @@ nsToolkitProfileService::Init()
     return NS_OK;
 }
 
 NS_IMETHODIMP
 nsToolkitProfileService::SetStartWithLastProfile(bool aValue)
 {
     if (mStartWithLast != aValue) {
         mStartWithLast = aValue;
-        mDirty = true;
     }
     return NS_OK;
 }
 
 NS_IMETHODIMP
 nsToolkitProfileService::GetStartWithLastProfile(bool *aResult)
 {
     *aResult = mStartWithLast;
@@ -642,17 +636,16 @@ nsToolkitProfileService::GetSelectedProf
     return NS_OK;
 }
 
 NS_IMETHODIMP
 nsToolkitProfileService::SetSelectedProfile(nsIToolkitProfile* aProfile)
 {
     if (mChosen != aProfile) {
         mChosen = aProfile;
-        mDirty = true;
     }
     return NS_OK;
 }
 
 NS_IMETHODIMP
 nsToolkitProfileService::GetDefaultProfile(nsIToolkitProfile* *aResult)
 {
     if (!mDefault) return NS_ERROR_FAILURE;
@@ -661,17 +654,16 @@ nsToolkitProfileService::GetDefaultProfi
     return NS_OK;
 }
 
 NS_IMETHODIMP
 nsToolkitProfileService::SetDefaultProfile(nsIToolkitProfile* aProfile)
 {
     if (mDefault != aProfile) {
         mDefault = aProfile;
-        mDirty = true;
     }
     return NS_OK;
 }
 
 NS_IMETHODIMP
 nsToolkitProfileService::GetProfileByName(const nsACString& aName,
                                           nsIToolkitProfile* *aResult)
 {