Backed out 2 changesets (bug 1584890) for crashtest failures on 1608851.html. CLOSED TREE
authorCsoregi Natalia <ncsoregi@mozilla.com>
Thu, 21 May 2020 04:05:52 +0300
changeset 531364 ec14e039b76a043d34c813d364b26e051d4a269d
parent 531363 e1d2e169db4ee4b25ecef6862411736e671cf76d
child 531365 7aaac87105b7e87c636057fec87311f60c50dd76
push id37438
push userabutkovits@mozilla.com
push dateThu, 21 May 2020 09:36:57 +0000
treeherdermozilla-central@2d00a1a6495c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1584890, 1608851
milestone78.0a1
backs out1da2faea06e80d252561993b9976a7777d911bbe
84d138356c7699456abf8dc6483b1d49aab86771
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 2 changesets (bug 1584890) for crashtest failures on 1608851.html. CLOSED TREE Backed out changeset 1da2faea06e8 (bug 1584890) Backed out changeset 84d138356c76 (bug 1584890)
layout/base/nsCSSFrameConstructor.cpp
testing/web-platform/tests/css/css-position/position-absolute-root-element-flex.html
testing/web-platform/tests/css/css-position/position-absolute-root-element-grid.html
testing/web-platform/tests/css/css-position/position-absolute-root-element-ref.html
testing/web-platform/tests/css/css-position/position-fixed-root-element-flex.html
testing/web-platform/tests/css/css-position/position-fixed-root-element-grid.html
testing/web-platform/tests/css/css-position/position-fixed-root-element-ref.html
--- a/layout/base/nsCSSFrameConstructor.cpp
+++ b/layout/base/nsCSSFrameConstructor.cpp
@@ -2299,22 +2299,19 @@ nsIFrame* nsCSSFrameConstructor::Constru
              display->mDisplay == StyleDisplay::WebkitBox ||
              display->mDisplay == StyleDisplay::Grid ||
              (StaticPrefs::layout_css_emulate_moz_box_with_flex() &&
               display->mDisplay == StyleDisplay::MozBox)) {
     auto func = display->mDisplay == StyleDisplay::Grid
                     ? NS_NewGridContainerFrame
                     : NS_NewFlexContainerFrame;
     contentFrame = func(mPresShell, computedStyle);
-    InitAndRestoreFrame(
-        state, aDocElement,
-        state.GetGeometricParent(*display, mDocElementContainingBlock),
-        contentFrame);
-    state.AddChild(contentFrame, frameList, aDocElement,
-                   mDocElementContainingBlock);
+    InitAndRestoreFrame(state, aDocElement, mDocElementContainingBlock,
+                        contentFrame);
+    frameList = {contentFrame, contentFrame};
     processChildren = true;
 
     contentFrame->AddStateBits(NS_FRAME_CAN_HAVE_ABSPOS_CHILDREN);
     if (display->IsAbsPosContainingBlock(contentFrame)) {
       state.PushAbsoluteContainingBlock(contentFrame, contentFrame,
                                         absoluteSaveState);
     }
   } else if (display->mDisplay == StyleDisplay::Table) {
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-position/position-absolute-root-element-flex.html
+++ /dev/null
@@ -1,30 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <meta charset="UTF-8">
-  <title>CSS Position: Box inset properties & position:absolute flex container as the root element</title>
-  <link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com"/>
-  <link rel="author" title="Ting-Yu Lin" href="mailto:tlin@mozilla.com">
-  <link rel="author" title="Mozilla" href="http://www.mozilla.org/">
-  <link rel="help" href="https://drafts.csswg.org/css-position-3/#insets">
-  <link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1584890">
-  <link rel="match" href="position-absolute-root-element-ref.html">
-  <meta name="assert" content="This test verifies the box inset properties on a position:absolute flex container root element.">
-
-  <style>
-  html {
-    display: flex;
-    position: absolute;
-    left: 10px;
-    right: 20px;
-    top: 30px;
-    bottom: 40px;
-    border: 5px dashed black;
-    box-sizing: border-box;
-  }
-  </style>
-
-  The black border should encompass the whole viewport,
-  with a bit of space on each side.
-  <br><br>
-  It shouldn't just shrinkwrap this text's height.
-</html>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-position/position-absolute-root-element-grid.html
+++ /dev/null
@@ -1,30 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <meta charset="UTF-8">
-  <title>CSS Position: Box inset properties & position:absolute grid container as the root element</title>
-  <link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com"/>
-  <link rel="author" title="Ting-Yu Lin" href="mailto:tlin@mozilla.com">
-  <link rel="author" title="Mozilla" href="http://www.mozilla.org/">
-  <link rel="help" href="https://drafts.csswg.org/css-position-3/#insets">
-  <link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1584890">
-  <link rel="match" href="position-absolute-root-element-ref.html">
-  <meta name="assert" content="This test verifies the box inset properties on a position:absolute grid container root element.">
-
-  <style>
-  html {
-    display: grid;
-    position: absolute;
-    left: 10px;
-    right: 20px;
-    top: 30px;
-    bottom: 40px;
-    border: 5px dashed black;
-    box-sizing: border-box;
-  }
-  </style>
-
-  The black border should encompass the whole viewport,
-  with a bit of space on each side.
-  <br><br>
-  It shouldn't just shrinkwrap this text's height.
-</html>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-position/position-absolute-root-element-ref.html
+++ /dev/null
@@ -1,26 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <meta charset="UTF-8">
-  <title>CSS Position Reference: Box inset properties & position:absolute root element</title>
-  <link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com"/>
-  <link rel="author" title="Ting-Yu Lin" href="mailto:tlin@mozilla.com">
-  <link rel="author" title="Mozilla" href="http://www.mozilla.org/">
-
-  <style>
-  html {
-    display: block;
-    position: absolute;
-    left: 10px;
-    right: 20px;
-    top: 30px;
-    bottom: 40px;
-    border: 5px dashed black;
-    box-sizing: border-box;
-  }
-  </style>
-
-  The black border should encompass the whole viewport,
-  with a bit of space on each side.
-  <br><br>
-  It shouldn't just shrinkwrap this text's height.
-</html>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-position/position-fixed-root-element-flex.html
+++ /dev/null
@@ -1,30 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <meta charset="UTF-8">
-  <title>CSS Position: Box inset properties & position:fixed flex container as the root element</title>
-  <link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com"/>
-  <link rel="author" title="Ting-Yu Lin" href="mailto:tlin@mozilla.com">
-  <link rel="author" title="Mozilla" href="http://www.mozilla.org/">
-  <link rel="help" href="https://drafts.csswg.org/css-position-3/#insets">
-  <link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1584890">
-  <link rel="match" href="position-fixed-root-element-ref.html">
-  <meta name="assert" content="This test verifies the box inset properties on a position:fixed flex container root element.">
-
-  <style>
-  html {
-    display: flex;
-    position: fixed;
-    left: 10px;
-    right: 20px;
-    top: 30px;
-    bottom: 40px;
-    border: 5px dashed black;
-    box-sizing: border-box;
-  }
-  </style>
-
-  The black border should encompass the whole viewport,
-  with a bit of space on each side.
-  <br><br>
-  It shouldn't just shrinkwrap this text's height.
-</html>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-position/position-fixed-root-element-grid.html
+++ /dev/null
@@ -1,30 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <meta charset="UTF-8">
-  <title>CSS Position: Box inset properties & position:fixed grid container as the root element</title>
-  <link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com"/>
-  <link rel="author" title="Ting-Yu Lin" href="mailto:tlin@mozilla.com">
-  <link rel="author" title="Mozilla" href="http://www.mozilla.org/">
-  <link rel="help" href="https://drafts.csswg.org/css-position-3/#insets">
-  <link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1584890">
-  <link rel="match" href="position-fixed-root-element-ref.html">
-  <meta name="assert" content="This test verifies the box inset properties on a position:fixed grid container root element.">
-
-  <style>
-  html {
-    display: grid;
-    position: fixed;
-    left: 10px;
-    right: 20px;
-    top: 30px;
-    bottom: 40px;
-    border: 5px dashed black;
-    box-sizing: border-box;
-  }
-  </style>
-
-  The black border should encompass the whole viewport,
-  with a bit of space on each side.
-  <br><br>
-  It shouldn't just shrinkwrap this text's height.
-</html>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-position/position-fixed-root-element-ref.html
+++ /dev/null
@@ -1,26 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <meta charset="UTF-8">
-  <title>CSS Position Reference: Box inset properties & position:fixed root element</title>
-  <link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com"/>
-  <link rel="author" title="Ting-Yu Lin" href="mailto:tlin@mozilla.com">
-  <link rel="author" title="Mozilla" href="http://www.mozilla.org/">
-
-  <style>
-  html {
-    display: block;
-    position: fixed;
-    left: 10px;
-    right: 20px;
-    top: 30px;
-    bottom: 40px;
-    border: 5px dashed black;
-    box-sizing: border-box;
-  }
-  </style>
-
-  The black border should encompass the whole viewport,
-  with a bit of space on each side.
-  <br><br>
-  It shouldn't just shrinkwrap this text's height.
-</html>