Bug 1381335 - Increase waitForCondition time for initial onboarding-overlay check. f=Fischer r=dmose
authorEd Lee <edilee@mozilla.com>
Sun, 16 Jul 2017 10:04:30 -0700
changeset 369186 ec0dc3ef3bf73ed9e8159b0c25b17a7fcab55129
parent 369185 c94795e8415360b8e192a2c47874d811e5614026
child 369187 5333e9eede4c32211182f448049ef4bf434ff699
push id32192
push userkwierso@gmail.com
push dateTue, 18 Jul 2017 00:01:01 +0000
treeherdermozilla-central@efc0b1525edb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmose
bugs1381335
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1381335 - Increase waitForCondition time for initial onboarding-overlay check. f=Fischer r=dmose Use the larger default 50 tries (and 100ms) on the initial loading of the overlay. MozReview-Commit-ID: 3qPt8w8yDNN
browser/extensions/onboarding/test/browser/head.js
--- a/browser/extensions/onboarding/test/browser/head.js
+++ b/browser/extensions/onboarding/test/browser/head.js
@@ -51,17 +51,17 @@ function promiseOnboardingOverlayLoaded(
         resolve(false);
       });
     })
   };
   return BrowserTestUtils.waitForCondition(
     condition,
     "Should load onboarding overlay",
     100,
-    30
+    50 // Bug 1381335 increased retries, so debug builds can trigger idle in time
   );
 }
 
 function promiseOnboardingOverlayOpened(browser) {
   let condition = () => {
     return ContentTask.spawn(browser, {}, function() {
       return new Promise(resolve => {
         let overlay = content.document.querySelector("#onboarding-overlay");