Bug 951674 - Vertical splitter isn't shown for the Events tab, r=fitzgen
☠☠ backed out by 7454e1c00067 ☠ ☠
authorVictor Porof <vporof@mozilla.com>
Wed, 18 Dec 2013 19:10:16 +0200
changeset 161090 eb4d2915ab262eab87ca762ced13629a89a4ca19
parent 161089 b48f948547efc7b04bb6d111935a19c18d83a268
child 161091 40978aa5238d1de302fc1f5782466f4d47ad19f2
push id25867
push userryanvm@gmail.com
push dateThu, 19 Dec 2013 02:19:33 +0000
treeherdermozilla-central@04a70c8908de [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfitzgen
bugs951674
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 951674 - Vertical splitter isn't shown for the Events tab, r=fitzgen
browser/devtools/shared/widgets/VariablesView.jsm
browser/themes/linux/devtools/debugger.css
browser/themes/linux/devtools/widgets.css
browser/themes/osx/devtools/debugger.css
browser/themes/osx/devtools/widgets.css
browser/themes/shared/devtools/common.css
browser/themes/shared/devtools/profiler.inc.css
browser/themes/shared/devtools/shadereditor.inc.css
browser/themes/windows/devtools/debugger.css
browser/themes/windows/devtools/widgets.css
--- a/browser/devtools/shared/widgets/VariablesView.jsm
+++ b/browser/devtools/shared/widgets/VariablesView.jsm
@@ -902,30 +902,28 @@ VariablesView.prototype = {
     if (this._emptyTextNode || !this._emptyTextValue) {
       return;
     }
 
     let label = this.document.createElement("label");
     label.className = "variables-view-empty-notice";
     label.setAttribute("value", this._emptyTextValue);
 
-    this._parent.setAttribute("empty", "");
     this._parent.appendChild(label);
     this._emptyTextNode = label;
   },
 
   /**
    * Removes the label signaling that this container is empty.
    */
   _removeEmptyNotice: function() {
     if (!this._emptyTextNode) {
       return;
     }
 
-    this._parent.removeAttribute("empty");
     this._parent.removeChild(this._emptyTextNode);
     this._emptyTextNode = null;
   },
 
   /**
    * Gets if all values should be aligned together.
    * @return boolean
    */
--- a/browser/themes/linux/devtools/debugger.css
+++ b/browser/themes/linux/devtools/debugger.css
@@ -9,17 +9,17 @@
   min-width: 50px;
 }
 
 #sources-pane > tabs {
   -moz-border-end: 1px solid #222426; /* Match the sources list's dark margin. */
 }
 
 #sources-and-editor-splitter {
-  -moz-border-start-color: transparent;
+  border-color: transparent;
 }
 
 /* Sources toolbar */
 
 #sources-toolbar {
   border: none; /* Remove the devtools-toolbar's black bottom border. */
   -moz-border-end: 1px solid #222426; /* Match the sources list's dark margin. */
 }
@@ -372,17 +372,17 @@
 }
 
 #globalsearch > vbox:not(:empty) {
   min-height: 10px;
   max-height: 125px;
 }
 
 #globalsearch + .devtools-horizontal-splitter {
-  -moz-border-top-colors: #bfbfbf;
+  border-color: #bfbfbf;
 }
 
 .dbg-source-results {
   padding: 0;
   background: none !important;
 }
 
 .dbg-results-header {
--- a/browser/themes/linux/devtools/widgets.css
+++ b/browser/themes/linux/devtools/widgets.css
@@ -266,17 +266,17 @@
 .breadcrumbs-widget-container[overflows] > .breadcrumbs-widget-item:last-of-type:-moz-locale-dir(rtl) {
   border-left-width: 0;
 }
 
 /* SideMenuWidget */
 
 .side-menu-widget-container {
   /* Hack: force hardware acceleration */
-  transform: translateX(0px);
+  transform: translateZ(1px);
 }
 
 .side-menu-widget-container[theme="dark"] {
   background: url(background-noise-toolbar.png), hsl(208,11%,27%);
   color: #fff;
 }
 
 .side-menu-widget-container[theme="light"] {
@@ -432,19 +432,19 @@
 .side-menu-widget-empty-notice-container[theme="light"] {
   background: #fff;
   padding: 4px 8px;
   color: GrayText;
 }
 
 /* VariablesView */
 
-.variables-view-container:not([empty]) {
+.variables-view-container {
   /* Hack: force hardware acceleration */
-  transform: translateX(1px);
+  transform: translateZ(1px);
 }
 
 .variables-view-empty-notice {
   color: GrayText;
   padding: 2px;
 }
 
 .variables-view-scope > .title {
--- a/browser/themes/osx/devtools/debugger.css
+++ b/browser/themes/osx/devtools/debugger.css
@@ -11,17 +11,17 @@
   min-width: 50px;
 }
 
 #sources-pane > tabs {
   -moz-border-end: 1px solid #222426; /* Match the sources list's dark margin. */
 }
 
 #sources-and-editor-splitter {
-  -moz-border-start-color: transparent;
+  border-color: transparent;
 }
 
 /* Sources toolbar */
 
 #sources-toolbar {
   border: none; /* Remove the devtools-toolbar's black bottom border. */
   -moz-border-end: 1px solid #222426; /* Match the sources list's dark margin. */
 }
@@ -374,17 +374,17 @@
 }
 
 #globalsearch > vbox:not(:empty) {
   min-height: 10px;
   max-height: 125px;
 }
 
 #globalsearch + .devtools-horizontal-splitter {
-  -moz-border-top-colors: #bfbfbf;
+  border-color: #bfbfbf;
 }
 
 .dbg-source-results {
   padding: 0;
   background: none !important;
 }
 
 .dbg-results-header {
--- a/browser/themes/osx/devtools/widgets.css
+++ b/browser/themes/osx/devtools/widgets.css
@@ -266,17 +266,17 @@
 .breadcrumbs-widget-container[overflows] > .breadcrumbs-widget-item:last-of-type:-moz-locale-dir(rtl) {
   border-left-width: 0;
 }
 
 /* SideMenuWidget */
 
 .side-menu-widget-container {
   /* Hack: force hardware acceleration */
-  transform: translateX(0px);
+  transform: translateZ(1px);
 }
 
 .side-menu-widget-container[theme="dark"] {
   background: url(background-noise-toolbar.png), hsl(208,11%,27%);
   color: #fff;
 }
 
 .side-menu-widget-container[theme="light"] {
@@ -426,19 +426,19 @@
 .side-menu-widget-empty-notice-container[theme="light"] {
   background: #fff;
   padding: 4px 8px;
   color: GrayText;
 }
 
 /* VariablesView */
 
-.variables-view-container:not([empty]) {
+.variables-view-container {
   /* Hack: force hardware acceleration */
-  transform: translateX(1px);
+  transform: translateZ(1px);
 }
 
 .variables-view-empty-notice {
   color: GrayText;
   padding: 2px;
 }
 
 .variables-view-scope > .title {
--- a/browser/themes/shared/devtools/common.css
+++ b/browser/themes/shared/devtools/common.css
@@ -21,33 +21,33 @@
 %endif
 }
 
 /* Splitters */
 .devtools-horizontal-splitter {
   -moz-appearance: none;
   background-image: none;
   background-color: transparent;
-  border: 1px solid black;
-  border-width: 1px 0 0 0;
+  border: 0;
+  border-bottom: 1px solid black;
   min-height: 3px;
   height: 3px;
-  margin-bottom: -3px;
+  margin-top: -2px;
   position: relative;
 }
 
 .devtools-side-splitter {
   -moz-appearance: none;
   background-image: none;
+  background-color: transparent;
   border: 0;
-  -moz-border-start: 1px solid black;
-  min-width: 0;
+  -moz-border-end: 1px solid black;
+  min-width: 3px;
   width: 3px;
-  background-color: transparent;
-  -moz-margin-end: -3px;
+  -moz-margin-start: -3px;
   position: relative;
   cursor: e-resize;
 }
 
 .devtools-toolbox-side-iframe {
   min-width: 465px;
 }
 
--- a/browser/themes/shared/devtools/profiler.inc.css
+++ b/browser/themes/shared/devtools/profiler.inc.css
@@ -8,25 +8,25 @@
   max-width: 176px;
   padding: 10px;
   background-color: rgb(61, 69, 76);
   color: white;
   font-weight: bold;
 }
 
 .devtools-toolbar {
-  min-height: 33px; 
+  min-height: 33px;
 }
 
 .profiler-sidebar {
   min-width: 196px;
 }
 
 .profiler-sidebar + .devtools-side-splitter {
-  -moz-border-start-color: transparent;
+  border-color: transparent;
 }
 
 .profiler-sidebar-item {
   padding: 3px 5px;
 }
 
 .profiler-sidebar-item, .side-menu-widget-item-contents {
   cursor: default;
@@ -81,9 +81,9 @@
 
 #profiler-start {
   list-style-image: url("chrome://browser/skin/devtools/profiler-stopwatch.png");
   -moz-image-region: rect(0px,16px,16px,0px);
 }
 
 #profiler-start[checked] {
   -moz-image-region: rect(0px,32px,16px,16px);
-}
\ No newline at end of file
+}
--- a/browser/themes/shared/devtools/shadereditor.inc.css
+++ b/browser/themes/shared/devtools/shadereditor.inc.css
@@ -41,17 +41,17 @@
 
 /* Shaders pane */
 
 #shaders-pane {
   min-width: 150px;
 }
 
 #shaders-pane + .devtools-side-splitter {
-  -moz-border-start-color: transparent;
+  border-color: transparent;
 }
 
 .side-menu-widget-item-checkbox {
   -moz-appearance: none;
   opacity: 0;
   transition: opacity .15s ease-out 0s;
 }
 
@@ -83,17 +83,17 @@
 
 .side-menu-widget-item-checkbox:not([checked]) ~ .side-menu-widget-item-contents {
   color: #888;
 }
 
 /* Shader source editors */
 
 #editors-splitter {
-  -moz-border-start-color: rgb(61,69,76);
+  border-color: rgb(61,69,76);
 }
 
 .editor-label {
   background: url(background-noise-toolbar.png), hsl(208,11%,27%);
   border-top: 1px solid #222426;
   padding: 1px 12px;
   color: #fff;
 }
--- a/browser/themes/windows/devtools/debugger.css
+++ b/browser/themes/windows/devtools/debugger.css
@@ -9,17 +9,17 @@
   min-width: 50px;
 }
 
 #sources-pane > tabs {
   -moz-border-end: 1px solid #222426; /* Match the sources list's dark margin. */
 }
 
 #sources-and-editor-splitter {
-  -moz-border-start-color: transparent;
+  border-color: transparent;
 }
 
 /* Sources toolbar */
 
 #sources-toolbar {
   border: none; /* Remove the devtools-toolbar's black bottom border. */
   -moz-border-end: 1px solid #222426; /* Match the sources list's dark margin. */
 }
@@ -372,17 +372,17 @@
 }
 
 #globalsearch > vbox:not(:empty) {
   min-height: 10px;
   max-height: 125px;
 }
 
 #globalsearch + .devtools-horizontal-splitter {
-  -moz-border-top-colors: #bfbfbf;
+  border-color: #bfbfbf;
 }
 
 .dbg-source-results {
   padding: 0;
   background: none !important;
 }
 
 .dbg-results-header {
--- a/browser/themes/windows/devtools/widgets.css
+++ b/browser/themes/windows/devtools/widgets.css
@@ -270,17 +270,17 @@
 .breadcrumbs-widget-container[overflows] > .breadcrumbs-widget-item:last-of-type:-moz-locale-dir(rtl) {
   border-left-width: 0;
 }
 
 /* SideMenuWidget */
 
 .side-menu-widget-container {
   /* Hack: force hardware acceleration */
-  transform: translateX(0px);
+  transform: translateZ(1px);
 }
 
 .side-menu-widget-container[theme="dark"] {
   background: url(background-noise-toolbar.png), hsl(208,11%,27%);
   color: #fff;
 }
 
 .side-menu-widget-container[theme="light"] {
@@ -429,19 +429,19 @@
 .side-menu-widget-empty-notice-container[theme="light"] {
   background: #fff;
   padding: 4px 8px;
   color: GrayText;
 }
 
 /* VariablesView */
 
-.variables-view-container:not([empty]) {
+.variables-view-container {
   /* Hack: force hardware acceleration */
-  transform: translateX(1px);
+  transform: translateZ(1px);
 }
 
 .variables-view-empty-notice {
   color: GrayText;
   padding: 2px;
 }
 
 .variables-view-scope > .title {