Bug 388971: Enable the 'make check' test checking for bad relocations. r=bsmedberg
authorL. David Baron <dbaron@dbaron.org>
Tue, 03 Dec 2013 12:51:08 -0800
changeset 158653 eadaf7446c64cd3947b2c8ab3555fa477d3ee714
parent 158652 5bdb9cff69ccd6966201fa6c5fbdefc7bdfb3890
child 158654 38ddf36afa9d7c40745c7ba556c92099e9ef82a7
push id25752
push usercbook@mozilla.com
push dateWed, 04 Dec 2013 08:35:03 +0000
treeherdermozilla-central@8187818246ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbsmedberg
bugs388971
milestone28.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 388971: Enable the 'make check' test checking for bad relocations. r=bsmedberg
Makefile.in
--- a/Makefile.in
+++ b/Makefile.in
@@ -241,17 +241,17 @@ maybe_clobber_profiledbuild:
 	find $(DIST)/$(MOZ_APP_NAME) -name '*.pgc' -exec mv {} $(DIST)/bin \;
 endif
 
 .PHONY: maybe_clobber_profiledbuild
 
 # Look for R_386_PC32 relocations in shared libs, these
 # break x86_64 builds and SELinux users.
 ifeq ($(OS_TARGET)_$(TARGET_XPCOM_ABI),Linux_x86-gcc3)
-scheck::
+check::
 	@relcount=`find $(DIST)/bin -name '*.so' | xargs objdump -R | grep R_386_PC32 | wc -l` && if test $$relcount -gt 0; then echo 'FAILED: R_386_PC32 relocations detected in a shared library.  Did you use a system header without adding it to config/system-headers?'; exit 1; else echo 'PASSED'; fi
 endif
 
 ifdef BUILD_JS
 js/src/Makefile: subsrcdir := js/src
 
 ifdef MOZ_PSEUDO_DERECURSE
 # Interdependencies for parallel export.