No bug: Fix obsolete comment on js::DebugScript::stepMode. DONTBUILD rs=jorendorff
authorJim Blandy <jimb@mozilla.com>
Mon, 15 Apr 2019 18:00:59 -0700
changeset 469744 ea66edd6bf0b
parent 469660 258af4e91151
child 469745 3dcc6eec59f4
push id35881
push usercbrindusan@mozilla.com
push dateWed, 17 Apr 2019 09:38:58 +0000
treeherdermozilla-central@bbca68b2af26 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug: Fix obsolete comment on js::DebugScript::stepMode. DONTBUILD rs=jorendorff
js/src/vm/JSScript.h
--- a/js/src/vm/JSScript.h
+++ b/js/src/vm/JSScript.h
@@ -248,21 +248,20 @@ using ScriptVTuneIdMap =
     HashMap<JSScript*, uint32_t, DefaultHasher<JSScript*>, SystemAllocPolicy>;
 #endif
 
 class DebugScript {
   friend class ::JSScript;
   friend class JS::Realm;
 
   /*
-   * When non-zero, compile script in single-step mode. The top bit is set and
-   * cleared by setStepMode, as used by JSD. The lower bits are a count,
-   * adjusted by changeStepModeCount, used by the Debugger object. Only
-   * when the bit is clear and the count is zero may we compile the script
-   * without single-step support.
+   * When greater than zero, compile script in single-step mode, with VM calls
+   * to HandleDebugTrap before each bytecode instruction's code. This is a
+   * counter, adjusted by the incrementStepModeCount and decrementStepModeCount
+   * methods.
    */
   uint32_t stepMode;
 
   /*
    * Number of breakpoint sites at opcodes in the script. This is the number
    * of populated entries in DebugScript::breakpoints, below.
    */
   uint32_t numSites;