Bug 1523632 - Part 1: Wrap the extension private browsing label on details page r=mixedpuppy,flod
authorMark Striemer <mstriemer@mozilla.com>
Tue, 29 Jan 2019 19:52:53 +0000
changeset 455981 ea5bca13b8d2e9ba6c63af1bf69097a7f9b24b2b
parent 455980 7418e2fbef99190b81168fb874318fab26c0cba4
child 455982 c19692b8561d1a599d79ccb251e6837781c28bc1
push id35465
push usershindli@mozilla.com
push dateWed, 30 Jan 2019 04:10:12 +0000
treeherdermozilla-central@9e919be867b3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmixedpuppy, flod
bugs1523632
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523632 - Part 1: Wrap the extension private browsing label on details page r=mixedpuppy,flod Differential Revision: https://phabricator.services.mozilla.com/D17964
toolkit/locales/en-US/toolkit/about/aboutAddons.ftl
toolkit/mozapps/extensions/content/extensions.xul
--- a/toolkit/locales/en-US/toolkit/about/aboutAddons.ftl
+++ b/toolkit/locales/en-US/toolkit/about/aboutAddons.ftl
@@ -122,18 +122,17 @@ detail-update-automatic =
     .label = On
     .tooltiptext = Automatically install updates
 
 detail-update-manual =
     .label = Off
     .tooltiptext = Don’t automatically install updates
 
 # Used as a description for the option to allow or block an add-on in private windows.
-detail-private-browsing =
-    .value = Run in Private Windows
+detail-private-browsing-label = Run in Private Windows
 
 detail-private-browsing-description = Extension will work in Private Windows, and have access to your online activities. <label data-l10n-name="detail-private-browsing-learn-more">Learn more</label>
 
 detail-private-browsing-on =
     .label = Allow
     .tooltiptext = Enable in Private Browsing
 
 detail-private-browsing-off =
--- a/toolkit/mozapps/extensions/content/extensions.xul
+++ b/toolkit/mozapps/extensions/content/extensions.xul
@@ -542,17 +542,17 @@
                       </vbox>
                       <grid id="detail-grid">
                         <columns>
                            <column flex="1"/>
                            <column flex="2"/>
                         </columns>
                         <rows id="detail-rows">
                           <row class="detail-row-complex" id="detail-privateBrowsing-row">
-                            <label class="detail-row-label" data-l10n-id="detail-private-browsing"/>
+                            <label class="detail-row-label" data-l10n-id="detail-private-browsing-label"/>
                             <hbox align="center">
                               <radiogroup id="detail-privateBrowsing" orient="horizontal">
                                 <radio data-l10n-id="detail-private-browsing-on"
                                        value="1"/>
                                 <radio data-l10n-id="detail-private-browsing-off"
                                        value="0"/>
                               </radiogroup>
                             </hbox>