Bug 1613958 - set correct treeherder platform names for macOS webrender and condprof tasks. r=chmanchester
authorSebastian Hengst <archaeopteryx@coole-files.de>
Fri, 07 Feb 2020 20:48:13 +0000
changeset 512979 ea0c8ca487f6e68e19495036d945b398059a6885
parent 512978 a16dc4e5cc1e39e3b71d79716988044a63dbdd9a
child 512980 37ffe2e2412b1a3c33c41977d3e537161f150e85
push id37105
push userapavel@mozilla.com
push dateMon, 10 Feb 2020 09:39:12 +0000
treeherdermozilla-central@4c08723ed20a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschmanchester
bugs1613958
milestone74.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1613958 - set correct treeherder platform names for macOS webrender and condprof tasks. r=chmanchester Some webrender and condprof tasks on macOS had raw/'ugly' platform names and were listed at the top of a treeherder push due to that and not together with the other OS X tasks. With this patch applied, they are shown together with the other tasks on that platform. The platform name should reference either cross compile or the platform version it is running on. Differential Revision: https://phabricator.services.mozilla.com/D62051
taskcluster/ci/condprof/kind.yml
taskcluster/ci/generate-profile/kind.yml
taskcluster/ci/instrumented-build/kind.yml
taskcluster/ci/webrender/kind.yml
--- a/taskcluster/ci/condprof/kind.yml
+++ b/taskcluster/ci/condprof/kind.yml
@@ -84,17 +84,17 @@ jobs:
                 - name: public/condprof
                   path: /builds/worker/archive
                   type: directory
     macosx64-firefox:
         worker-type: t-osx-1014
         description: Creates or updates conditioned profiles on macOS
         treeherder:
             symbol: condprof(firefox)
-            platform: macosx64/opt
+            platform: macosx1014-64/opt
         dependencies:
             build-macosx64/opt: build-macosx64/opt
         fetches:
             build-macosx64/opt:
                 - artifact: target.common.tests.tar.gz
                 - artifact: target.condprof.tests.tar.gz
                 - artifact: target.dmg
         index:
--- a/taskcluster/ci/generate-profile/kind.yml
+++ b/taskcluster/ci/generate-profile/kind.yml
@@ -178,17 +178,17 @@ jobs:
     macosx64-shippable/opt:
         description: "macosx64 Profile Generation"
         shipping-phase: build
         shipping-product: firefox
         index:
             product: firefox
             job-name: macosx64-profile
         treeherder:
-            platform: macosx64-shippable/opt
+            platform: macosx1014-64-shippable/opt
         worker-type: t-osx-1014-pgo
         worker:
             max-run-time: 7200
             env:
                 SHELL: "/bin/bash"
             artifacts:
                 - type: directory
                   name: public/build
--- a/taskcluster/ci/instrumented-build/kind.yml
+++ b/taskcluster/ci/instrumented-build/kind.yml
@@ -86,17 +86,17 @@ jobs:
                 - linux64-lucetc
                 - wasi-sysroot
 
     macosx64-shippable/opt:
         description: "MacOS X x64 Cross-compile Instrumented"
         shipping-phase: build
         shipping-product: firefox
         treeherder:
-            platform: macosx64-shippable/opt
+            platform: osx-shippable/opt
         worker-type: b-linux
         worker:
             max-run-time: 7200
             env:
                 PERFHERDER_EXTRA_OPTIONS: instrumented
                 TOOLTOOL_MANIFEST: "browser/config/tooltool-manifests/macosx64/cross-releng.manifest"
         run:
             using: mozharness
--- a/taskcluster/ci/webrender/kind.yml
+++ b/taskcluster/ci/webrender/kind.yml
@@ -115,17 +115,17 @@ jobs:
                 - linux64-clang
                 - linux64-llvm-dsymutil
                 - wrench-deps
         run:
             using: run-task
             tooltool-downloads: internal
             command: '$HOME/checkouts/gecko/taskcluster/scripts/misc/wrench-macos-build.sh'
         treeherder:
-            platform: macosx64-qr/opt
+            platform: osx-cross/opt
             symbol: WR(B)
         when:
             files-changed:
                 - 'gfx/wr/**'
                 - 'taskcluster/scripts/misc/tooltool-download.sh'
                 - 'taskcluster/scripts/misc/wr-macos-cross-build-setup.sh'
                 - 'taskcluster/scripts/misc/wrench-macos-build.sh'
 
@@ -145,17 +145,17 @@ jobs:
         run:
             using: run-task
             cwd: '{checkout}/gfx/wr'
             command: >-
                 export WRENCH_HEADLESS_TARGET=$PWD/wrench-macos-headless/ &&
                 export WRENCH_BINARY=$PWD/wrench-macos/bin/wrench &&
                 ci-scripts/macos-release-tests.sh
         treeherder:
-            platform: macosx64-qr/opt
+            platform: macosx1014-64-qr/opt
             symbol: WR(wrench)
         when:
             files-changed:
                 - 'gfx/wr/**'
 
     cargotest-macos-build:
         description: Cross compilation of cargo tests for macOS on Linux
         worker-type: b-linux
@@ -175,17 +175,17 @@ jobs:
                 - linux64-clang
                 - linux64-llvm-dsymutil
                 - wrench-deps
         run:
             using: run-task
             tooltool-downloads: internal
             command: '$HOME/checkouts/gecko/taskcluster/scripts/misc/wr-cargotest-macos-build.sh'
         treeherder:
-            platform: macosx64-qr/debug
+            platform: osx-cross/debug
             symbol: WR(B)
         when:
             files-changed:
                 - 'gfx/wr/**'
                 - 'taskcluster/scripts/misc/tooltool-download.sh'
                 - 'taskcluster/scripts/misc/wr-cargotest-macos-build.sh'
                 - 'taskcluster/scripts/misc/wr-macos-cross-build-setup.sh'
 
@@ -204,17 +204,17 @@ jobs:
         run:
             using: run-task
             cwd: '{checkout}/gfx/wr'
             command: >-
                 mv cargo-test-binaries target &&
                 cd target &&
                 for i in debug/*; do $i; done
         treeherder:
-            platform: macosx64-qr/debug
+            platform: macosx1014-64-qr/debug
             symbol: WR(cargotest)
         when:
             files-changed:
                 - 'gfx/wr/**'
 
     windows:
         description: Runs WebRender CI tests on a Windows worker
         worker-type: t-win10-64