Bug 1083539: Fix dropped return value check (r=keeler)
authorMonica Chew <mmc@mozilla.com>
Thu, 23 Oct 2014 17:07:45 -0700
changeset 212251 e981fd5453dc71703d19408bbf78d1ad8685e6da
parent 212250 d4845054ea1823f0a3be3ca6f741bee59706f1d8
child 212252 cd13fcbf38538c9166849279fc4a7e83743e915f
push id27702
push userkwierso@gmail.com
push dateFri, 24 Oct 2014 22:05:50 +0000
treeherdermozilla-central@c70f62375f7d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskeeler
bugs1083539
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1083539: Fix dropped return value check (r=keeler)
security/pkix/lib/pkixocsp.cpp
--- a/security/pkix/lib/pkixocsp.cpp
+++ b/security/pkix/lib/pkixocsp.cpp
@@ -776,16 +776,19 @@ KeyHash(TrustDomain& trustDomain, const 
   //
   // SubjectPublicKeyInfo  ::=  SEQUENCE  {
   //    algorithm            AlgorithmIdentifier,
   //    subjectPublicKey     BIT STRING  }
 
   Reader spki;
   Result rv = der::ExpectTagAndGetValueAtEnd(subjectPublicKeyInfo,
                                              der::SEQUENCE, spki);
+  if (rv != Success) {
+    return rv;
+  }
 
   // Skip AlgorithmIdentifier
   rv = der::ExpectTagAndSkipValue(spki, der::SEQUENCE);
   if (rv != Success) {
     return rv;
   }
 
   Input subjectPublicKey;