Bug 1628052 - Remove uses of dom.ipc.keepProcessesAlive.webIsolated.perOrigin to fix leaks. r=kmag
authorAndrew McCreight <continuation@gmail.com>
Tue, 28 Apr 2020 20:11:27 +0000
changeset 526554 e8cf96fbbc64df5b2e6c44acffa2498959eebe5f
parent 526553 632035e7c6842ed4e525cdd124a22446ae1bb375
child 526555 578d8d0d8c6e202078409f99846c70a5e07b54a8
push id37358
push useropoprus@mozilla.com
push dateWed, 29 Apr 2020 03:05:14 +0000
treeherdermozilla-central@6bb8423186c1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag
bugs1628052
milestone77.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1628052 - Remove uses of dom.ipc.keepProcessesAlive.webIsolated.perOrigin to fix leaks. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D70076
browser/base/content/test/tabs/browser.ini
browser/components/extensions/test/browser/browser.ini
browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
browser/components/uitour/test/browser.ini
browser/components/urlbar/tests/browser/browser.ini
toolkit/components/reader/test/browser.ini
--- a/browser/base/content/test/tabs/browser.ini
+++ b/browser/base/content/test/tabs/browser.ini
@@ -1,14 +1,9 @@
 [DEFAULT]
-prefs =
-    # With Fission enabled, this directory spawns many child processes, which
-    # somehow results in frequent shutdown leaks. Reuse the content processes
-    # to avoid this.
-    dom.ipc.keepProcessesAlive.webIsolated.perOrigin=1
 support-files =
   head.js
   dummy_page.html
   ../general/audio.ogg
   file_mediaPlayback.html
   test_process_flags_chrome.html
 
 [browser_accessibility_indicator.js]
--- a/browser/components/extensions/test/browser/browser.ini
+++ b/browser/components/extensions/test/browser/browser.ini
@@ -1,17 +1,17 @@
 [DEFAULT]
 tags = webextensions
 prefs =
     # We don't want to reset this at the end of the test, so that we don't have
     # to spawn a new extension child process for each test unit.
     dom.ipc.keepProcessesAlive.extension=1
     # With Fission enabled, this directory spawns many child processes, which
-    # somehow results in frequent leaks and shutdown hangs. Reuse the content
-    # processes to avoid this.
+    # somehow results in frequent shutdown hangs. Reuse the content processes to
+    # avoid this.
     dom.ipc.keepProcessesAlive.webIsolated.perOrigin=1
     dom.animations-api.core.enabled=true
     dom.animations-api.timelines.enabled=true
     plugin.load_flash_only=false
 support-files =
   head.js
   head_devtools.js
   silence.ogg
--- a/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
+++ b/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
@@ -1,23 +1,18 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 // This test makes sure that the geolocation prompt does not show a remember
 // control inside the private browsing mode.
 
-// This test leaks intermittently with Fission. Make it behave more like
-// non-Fission e10s tests to try to avoid them.
 add_task(async function setup() {
   await SpecialPowers.pushPrefEnv({
-    set: [
-      ["dom.ipc.keepProcessesAlive.webIsolated.perOrigin", 1],
-      ["dom.vr.always_support_vr", true],
-    ],
+    set: [["dom.vr.always_support_vr", true]],
   });
 });
 
 add_task(async function test() {
   function checkPrompt(aURL, aName, aPrivateMode, aWindow) {
     return (async function() {
       aWindow.gBrowser.selectedTab = BrowserTestUtils.addTab(
         aWindow.gBrowser,
--- a/browser/components/uitour/test/browser.ini
+++ b/browser/components/uitour/test/browser.ini
@@ -1,13 +1,13 @@
 [DEFAULT]
 prefs =
     # With Fission enabled, this directory spawns many child processes, which
-    # somehow results in frequent shutdown leaks and hangs. Reuse the content
-    # processes to avoid this.
+    # somehow results in frequent shutdown hangs. Reuse the content processes to
+    # avoid this.
     dom.ipc.keepProcessesAlive.webIsolated.perOrigin=1
 support-files =
   head.js
   image.png
   uitour.html
   ../UITour-lib.js
 
 [browser_backgroundTab.js]
--- a/browser/components/urlbar/tests/browser/browser.ini
+++ b/browser/components/urlbar/tests/browser/browser.ini
@@ -2,21 +2,16 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 [DEFAULT]
 support-files =
   dummy_page.html
   head.js
   head-common.js
-prefs =
-    # With Fission enabled, these tests spawns many child processes, which
-    # somehow results in frequent shutdown leaks. Reuse the content processes
-    # to avoid this.
-    dom.ipc.keepProcessesAlive.webIsolated.perOrigin=1
 
 [browser_aboutHomeLoading.js]
 [browser_action_searchengine.js]
 [browser_action_searchengine_alias.js]
 [browser_autocomplete_a11y_label.js]
 support-files =
   searchSuggestionEngine.xml
   searchSuggestionEngine.sjs
--- a/toolkit/components/reader/test/browser.ini
+++ b/toolkit/components/reader/test/browser.ini
@@ -1,13 +1,13 @@
 [DEFAULT]
 prefs =
     # With Fission enabled, this directory spawns many child processes, which
-    # somehow results in frequent shutdown leaks. Reuse the content processes
-    # to avoid this. See bug 1594572.
+    # somehow results in frequent shutdown hangs. Reuse the content processes to
+    # avoid this. See bug 1594572.
     dom.ipc.keepProcessesAlive.webIsolated.perOrigin=1
 support-files = head.js
 [browser_readerMode.js]
 support-files =
   readerModeNonArticle.html
   readerModeArticle.html
   readerModeArticleHiddenNodes.html
 [browser_readerMode_hidden_nodes.js]