Bug 853972 - Followup, add a return in the case that alertWindow is null. r=me
☠☠ backed out by 97d423929fc6 ☠ ☠
authorJared Wein <jwein@mozilla.com>
Mon, 13 Jan 2014 15:46:23 +0100
changeset 163163 e8b0b4daa733da06b2ee353500faaaacb4168fad
parent 163162 e9f1c39fe072f665325feaee19191467d9e81228
child 163164 f5986233db46eb02b878c0aacb9bea75fa6d02c8
push id25983
push userryanvm@gmail.com
push dateMon, 13 Jan 2014 22:37:56 +0000
treeherdermozilla-central@34697b7131dd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs853972
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 853972 - Followup, add a return in the case that alertWindow is null. r=me
browser/base/content/test/general/browser_notification_tab_switching.js
--- a/browser/base/content/test/general/browser_notification_tab_switching.js
+++ b/browser/base/content/test/general/browser_notification_tab_switching.js
@@ -37,16 +37,17 @@ function onAlertShowing() {
   notification.removeEventListener("show", onAlertShowing);
 
   gBrowser.tabContainer.addEventListener("TabSelect", onTabSelect);
   let alertWindow = findChromeWindowByURI("chrome://global/content/alerts/alert.xul");
   if (!alertWindow) {
     todo("Notifications don't use XUL windows on all platforms.");
     notification.close();
     finish();
+    return;
   }
   EventUtils.synthesizeMouseAtCenter(alertWindow.document.getElementById("alertTitleLabel"), {});
   alertWindow.close();
 }
 
 function onTabSelect() {
   gBrowser.tabContainer.removeEventListener("TabSelect", onTabSelect);
   is(gBrowser.selectedTab.linkedBrowser.contentWindow.location.href, notificationURL,