Bug 1514587: Add missing cast for typed enum comparison. r=jorendorff
authorAndré Bargull <andre.bargull@gmail.com>
Mon, 17 Dec 2018 05:56:49 -0800
changeset 451134 e86ac796f667d52a57337258a9b9cbbb3a803fca
parent 451133 52c826ca76316b13995bb4cd73024b2b987dcd93
child 451135 3fcc7597cd8dc5b88ac288d809355b9865f7da41
push id35227
push usercbrindusan@mozilla.com
push dateTue, 18 Dec 2018 17:34:45 +0000
treeherdermozilla-central@1a7fb4c17553 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
bugs1514587
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1514587: Add missing cast for typed enum comparison. r=jorendorff
js/src/builtin/Symbol.cpp
--- a/js/src/builtin/Symbol.cpp
+++ b/js/src/builtin/Symbol.cpp
@@ -60,17 +60,17 @@ JSObject* SymbolObject::initClass(JSCont
   if (defineMembers) {
     // Define the well-known symbol properties, such as Symbol.iterator.
     ImmutablePropertyNamePtr* names = cx->names().wellKnownSymbolNames();
     RootedValue value(cx);
     unsigned attrs = JSPROP_READONLY | JSPROP_PERMANENT;
     WellKnownSymbols* wks = cx->runtime()->wellKnownSymbols;
     for (size_t i = 0; i < JS::WellKnownSymbolLimit; i++) {
 #ifndef NIGHTLY_BUILD
-      if (i == SymbolCode::matchAll) {
+      if (i == static_cast<size_t>(SymbolCode::matchAll)) {
         continue;
       }
 #endif
       value.setSymbol(wks->get(i));
       if (!NativeDefineDataProperty(cx, ctor, names[i], value, attrs)) {
         return nullptr;
       }
     }