Bug 613092: return NULL instead of JS_FALSE from method 'addScript' whose return type is a pointer (in jsdbgapi.cpp). r=dmandelin
authorDaniel Holbert <dholbert@cs.stanford.edu>
Tue, 21 Dec 2010 16:07:17 -0800
changeset 59912 e852f9426d25059502162ac18d445f229ac23636
parent 59911 8bb016a281c0911c309aba008e10c58b5c3a9289
child 59913 a4f9580c9b72328c944220e08a3bb4e0232c6e98
push id17820
push usercleary@mozilla.com
push dateTue, 04 Jan 2011 21:40:57 +0000
treeherdermozilla-central@969691cfe40e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmandelin
bugs613092
milestone2.0b8pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 613092: return NULL instead of JS_FALSE from method 'addScript' whose return type is a pointer (in jsdbgapi.cpp). r=dmandelin
js/src/jsdbgapi.cpp
--- a/js/src/jsdbgapi.cpp
+++ b/js/src/jsdbgapi.cpp
@@ -2271,17 +2271,17 @@ public:
     bool isEmpty() {
         return (mReadPos == mWritePos);
     }
 
     EthogramScriptEntry *addScript(JSContext *cx, JSObject *obj, char *filename, JSString *jsfilename) {
         JSHashNumber hash = JS_HashString(filename);
         JSHashEntry **hep = JS_HashTableRawLookup(traceVisScriptTable, hash, filename);
         if (*hep != NULL)
-            return JS_FALSE;
+            return NULL;
 
         JS_HashTableRawAdd(traceVisScriptTable, hep, hash, filename, this);
 
         EthogramScriptEntry * entry = (EthogramScriptEntry *) JS_malloc(cx, sizeof(EthogramScriptEntry));
         if (entry == NULL)
             return NULL;
 
         entry->next = mScripts;