Bug 1474132 - Choose right add-on icon size in about:addons and install popup r=rpl
authorOriol Brufau <oriol-bugzilla@hotmail.com>
Fri, 13 Jul 2018 13:51:28 +0200
changeset 427142 e75b08486dc66b54be10fd8b49502ecc9c894f75
parent 427141 547dc7e730a79d8079718ffe3a4c1a05a23017a7
child 427143 1fafb8e07051ccf79a2fa5364d334baa7ac83f10
push id34294
push usershindli@mozilla.com
push dateWed, 18 Jul 2018 21:44:46 +0000
treeherdermozilla-central@7ad45eaf20ca [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrpl
bugs1474132
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1474132 - Choose right add-on icon size in about:addons and install popup r=rpl MozReview-Commit-ID: L5O2OwlK879
browser/modules/ExtensionsUI.jsm
toolkit/mozapps/extensions/content/extensions.xml
--- a/browser/modules/ExtensionsUI.jsm
+++ b/browser/modules/ExtensionsUI.jsm
@@ -404,17 +404,17 @@ var ExtensionsUI = {
     return new Promise(resolve => {
       let action = {
         label: bundle.getString("addonPostInstall.okay.label"),
         accessKey: bundle.getString("addonPostInstall.okay.key"),
         callback: resolve,
       };
 
       let icon = addon.isWebExtension ?
-                 addon.iconURL || DEFAULT_EXTENSION_ICON :
+                 AddonManager.getPreferredIconURL(addon, 32, window) || DEFAULT_EXTENSION_ICON :
                  "chrome://browser/skin/addons/addon-install-installed.svg";
       let options = {
         hideClose: true,
         timeout: Date.now() + 30000,
         popupIconURL: icon,
         eventCallback(topic) {
           if (topic == "dismissed") {
             resolve();
--- a/toolkit/mozapps/extensions/content/extensions.xml
+++ b/toolkit/mozapps/extensions/content/extensions.xml
@@ -909,17 +909,17 @@
           this.mAddon = aAddon;
 
           this._installStatus.mAddon = this.mAddon;
           this._updateDates();
           this._updateState();
 
           this.setAttribute("name", aAddon.name);
 
-          var iconURL = AddonManager.getPreferredIconURL(aAddon, 48, window);
+          var iconURL = AddonManager.getPreferredIconURL(aAddon, 32, window);
           if (iconURL)
             this._icon.src = iconURL;
           else
             this._icon.src = "";
 
           if (this.mAddon.description)
             this._description.value = this.mAddon.description;
           else