Bug 1545217 - Skip gtest TestThreads.cpp on android again; r=jmaher
authorGeoff Brown <gbrown@mozilla.com>
Tue, 07 May 2019 14:20:58 +0000
changeset 472900 e6e096360c85a5c694f415667fe6a108f0238bf4
parent 472899 d7eaeddfd71d0eac39d7e99bbc918fc1df62bedf
child 472901 4db69eae737243de67e3eecf4b4afbba34921471
push id35983
push userncsoregi@mozilla.com
push dateWed, 08 May 2019 03:38:51 +0000
treeherdermozilla-central@0e9e744accd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1545217
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1545217 - Skip gtest TestThreads.cpp on android again; r=jmaher I enabled this test yesterday, but it turns out it still crashes intermittently: https://treeherder.mozilla.org/logviewer.html#?job_id=245063009&repo=autoland https://taskcluster-artifacts.net/DJEiHJaJRaCYMWk2UMoR8A/0/public/test_info//logcat-emulator-5554.log 05-07 08:47:38.460 2530 2545 I gtest : TEST-START | Threads.Main --------- beginning of crash 05-07 08:47:38.570 2530 2545 F libc : stack corruption detected 05-07 08:47:38.570 2530 2545 W google-breakpad: ExceptionHandler::GenerateDump cloned child Differential Revision: https://phabricator.services.mozilla.com/D30198
xpcom/tests/gtest/moz.build
--- a/xpcom/tests/gtest/moz.build
+++ b/xpcom/tests/gtest/moz.build
@@ -51,26 +51,26 @@ UNIFIED_SOURCES += [
     'TestTArray.cpp',
     'TestTArray2.cpp',
     'TestTaskQueue.cpp',
     'TestTextFormatter.cpp',
     'TestThreadManager.cpp',
     'TestThreadMetrics.cpp',
     'TestThreadPool.cpp',
     'TestThreadPoolListener.cpp',
-    'TestThreads.cpp',
     'TestThrottledEventQueue.cpp',
     'TestTimeStamp.cpp',
     'TestTokenizer.cpp',
     'TestUTF.cpp',
 ]
 
 if CONFIG['OS_TARGET'] != 'Android':
     UNIFIED_SOURCES += [
         'TestPipes.cpp',
+        'TestThreads.cpp',
     ]
 
 # skip the test on windows10-aarch64 due to perma-fail, bug 1422219
 if not(CONFIG['OS_TARGET'] == 'WINNT' and CONFIG['CPU_ARCH'] == 'aarch64'):
     UNIFIED_SOURCES += [
         'TestThreadUtils.cpp'
     ]