servo: Merge #10942 - Rename check_no_unwrap.sh to check_no_panic.sh (from 6br:rename_check_no_panic); r=aneeshusa
author6br <ina_univ-science@yahoo.co.jp>
Sat, 29 Oct 2016 00:22:56 -0500
changeset 340012 e6d6c6308d2207d1e2683d05f7dd6ef750120fe9
parent 340011 9fa475f42bce1932727832e624a775cd06a0b678
child 340013 ada09f0c0ebd0997e6186048a445ac75abf1c283
push id31307
push usergszorc@mozilla.com
push dateSat, 04 Feb 2017 00:59:06 +0000
treeherdermozilla-central@94079d43835f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaneeshusa
servo: Merge #10942 - Rename check_no_unwrap.sh to check_no_panic.sh (from 6br:rename_check_no_panic); r=aneeshusa Hello, I fixed #10930. Source-Repo: https://github.com/servo/servo Source-Revision: 3ae0a3335dbaf3f67c775a1853941ed538d97563
servo/.travis.yml
servo/etc/ci/buildbot_steps.yml
servo/etc/ci/check_no_panic.sh
servo/etc/ci/check_no_unwrap.sh
--- a/servo/.travis.yml
+++ b/servo/.travis.yml
@@ -11,17 +11,17 @@ matrix:
     - sudo: 9000
       dist: trusty
       script:
          - ./mach build -d --verbose
          - ./mach test-compiletest
          - ./mach test-unit
          - ./mach build-geckolib
          - ./mach test-stylo
-         - bash etc/ci/check_no_unwrap.sh
+         - bash etc/ci/check_no_panic.sh
          - bash etc/ci/lockfile_changed.sh
          - bash etc/ci/manifest_changed.sh
       cache:
         directories:
           - .cargo
           - .servo
           - $HOME/.ccache
       env: CCACHE=/usr/bin/ccache
--- a/servo/etc/ci/buildbot_steps.yml
+++ b/servo/etc/ci/buildbot_steps.yml
@@ -47,17 +47,17 @@ linux-dev:
   - ./mach build --dev
   - ./mach test-compiletest
   - ./mach test-unit
   - ./mach build-cef
   - ./mach build-geckolib
   - ./mach test-stylo
   - bash ./etc/ci/lockfile_changed.sh
   - bash ./etc/ci/manifest_changed.sh
-  - bash ./etc/ci/check_no_unwrap.sh
+  - bash ./etc/ci/check_no_panic.sh
 
 linux-rel-wpt:
   - ./mach build --release
   - ./mach test-wpt-failure
   - ./mach test-wpt --release --processes 24 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log
   - ./mach test-wpt --release --binary-arg=--multiprocess --processes 24 --log-raw test-wpt-mp.log --log-errorsummary wpt-mp-errorsummary.log eventsource
 
 linux-rel-css:
rename from servo/etc/ci/check_no_unwrap.sh
rename to servo/etc/ci/check_no_panic.sh
--- a/servo/etc/ci/check_no_unwrap.sh
+++ b/servo/etc/ci/check_no_panic.sh
@@ -1,24 +1,23 @@
 #!/usr/bin/env bash
 
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-# Make sure listed files do not contain "unwrap"
+# Make sure listed files do not use unwrap() or panic!()
 
 set -o errexit
 set -o nounset
 set -o pipefail
 
 # cd into repo root to make sure paths work in any case
 cd "$(git rev-parse --show-toplevel)"
 
-# files that should not contain "unwrap"
 FILES=("components/compositing/compositor.rs"
        "components/constellation/constellation.rs"
        "components/constellation/pipeline.rs"
        "ports/glutin/lib.rs"
        "ports/glutin/window.rs")
 
 # make sure the files exist
 ls -1 "${FILES[@]}"