Bug 1444174 - point people away from Cargo.toml for opt-level settings of Rust code; r=nalexander
authorNathan Froyd <froydnj@mozilla.com>
Fri, 09 Mar 2018 09:31:17 -0500
changeset 407368 e6624d7d53efa376b598e6985dc5fa4edc0bfd87
parent 407367 9967aedb77babcddcb06a518e030c83538127eb1
child 407369 26fa0c926ba62c024fce837313ce3bf207d6faa4
push id33599
push userapavel@mozilla.com
push dateFri, 09 Mar 2018 19:34:23 +0000
treeherdermozilla-central@3dc420775cf0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1444174
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1444174 - point people away from Cargo.toml for opt-level settings of Rust code; r=nalexander For people who don't know how our Rust opt-level setup works--or for people who did know and repeatedly forget--it would be good to have some documentation in Cargo.toml pointing at the correct place.
Cargo.toml
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -34,17 +34,19 @@ exclude = [
   # Excluded because they are used only as dependencies, not top-level targets,
   # so we don't need to vendor their dev-dependencies.
   "dom/webauthn/u2f-hid-rs",
   "media/mp4parse-rust/mp4parse",
   "media/mp4parse-rust/mp4parse_capi",
   "media/mp4parse-rust/mp4parse_fallible",
 ]
 
-# Explicitly specify what our profiles use.
+# Explicitly specify what our profiles use.  The opt-level setting here is
+# a total fiction; see the setup of MOZ_RUST_DEFAULT_FLAGS for what the
+# opt-level setting will be as a result of various other configure flags.
 [profile.dev]
 opt-level = 1
 rpath = false
 lto = false
 debug-assertions = true
 panic = "abort"
 
 [profile.release]