Bug 1460379 - remove --with-pthreads option; r=ted.mielczarek
authorNathan Froyd <froydnj@mozilla.com>
Wed, 09 May 2018 17:26:31 -0400
changeset 417680 e61af28c3143645eb79a8245112863c0b702d7e4
parent 417679 2dd51c7e5789d45631e1e56b59ee02ac81e55b35
child 417681 0e851b076fddb5eee96c6349ab21479b23ecfc7a
push id33977
push userncsoregi@mozilla.com
push dateThu, 10 May 2018 16:43:24 +0000
treeherdermozilla-central@17db33b6a124 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1460379
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1460379 - remove --with-pthreads option; r=ted.mielczarek This option does nothing if it's provided, and things will probably break in some most peculiar manner if somebody uses --without-pthreads. Given that neither outcome is useful, we should remove the option.
build/moz.configure/old.configure
js/src/old-configure.in
old-configure.in
--- a/build/moz.configure/old.configure
+++ b/build/moz.configure/old.configure
@@ -254,17 +254,16 @@ def old_configure_options(*options):
     '--with-macos-private-frameworks',
     '--with-macos-sdk',
     '--with-nspr-cflags',
     '--with-nspr-exec-prefix',
     '--with-nspr-libs',
     '--with-nspr-prefix',
     '--with-nss-exec-prefix',
     '--with-nss-prefix',
-    '--with-pthreads',
     '--with-qemu-exe',
     '--with-sixgill',
     '--with-soft-float',
     '--with-system-bz2',
     '--with-system-icu',
     '--with-system-jpeg',
     '--with-system-libevent',
     '--with-system-libvpx',
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -976,28 +976,16 @@ darwin*)
                 )
             )
         )
     )
     ;;
 esac
 
 dnl ========================================================
-dnl Check the command line for --with-pthreads
-dnl ========================================================
-MOZ_ARG_WITH_BOOL(pthreads,
-[  --with-pthreads         Force use of system pthread library with NSPR ],
-[ if test "$USE_PTHREADS"x = x; then
-    AC_MSG_ERROR([ --with-pthreads specified for a system without pthread support ]);
-fi],
-    USE_PTHREADS=
-    _PTHREAD_LDFLAGS=
-)
-
-dnl ========================================================
 dnl Do the platform specific pthread hackery
 dnl ========================================================
 if test "$USE_PTHREADS"x != x
 then
 	dnl
 	dnl See if -pthread is supported.
 	dnl
 	rm -f conftest*
--- a/old-configure.in
+++ b/old-configure.in
@@ -1324,28 +1324,16 @@ darwin*)
                 )
             )
         )
     )
     ;;
 esac
 
 dnl ========================================================
-dnl Check the command line for --with-pthreads
-dnl ========================================================
-MOZ_ARG_WITH_BOOL(pthreads,
-[  --with-pthreads         Force use of system pthread library with NSPR ],
-[ if test "$MOZ_USE_PTHREADS"x = x; then
-    AC_MSG_ERROR([ --with-pthreads specified for a system without pthread support ]);
-fi],
-    MOZ_USE_PTHREADS=
-    _PTHREAD_LDFLAGS=
-)
-
-dnl ========================================================
 dnl Do the platform specific pthread hackery
 dnl ========================================================
 if test "$MOZ_USE_PTHREADS"x != x
 then
     dnl
     dnl See if -pthread is supported.
     dnl
     rm -f conftest*