servo: Merge #10363 - Issue #10357: mach run -b now passes additional params to servo (from autrilla:issue#10357); r=emilio
authorAdrian Utrilla <adrianutrilla@gmail.com>
Sat, 02 Apr 2016 17:31:43 +0500
changeset 338394 e5ae263909d12c99bc54e7db1a96ef1cebcd5c57
parent 338393 2694769ab4e2e4345cc34a1e6206ac7b67c04932
child 338395 917269d04ce9045a9322476a896f83614e0c84b3
push id31307
push usergszorc@mozilla.com
push dateSat, 04 Feb 2017 00:59:06 +0000
treeherdermozilla-central@94079d43835f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
servo: Merge #10363 - Issue #10357: mach run -b now passes additional params to servo (from autrilla:issue#10357); r=emilio Previously `./mach run` with the `-b` flag set ignored everything passed after the `--`, so for example when running `./mach run -d -b -- --help`, `--help` was not passed to servo - it is now. Source-Repo: https://github.com/servo/servo Source-Revision: 5e73e1015b588da6b641a7a4175e51430d9b7019
servo/python/servo/post_build_commands.py
--- a/servo/python/servo/post_build_commands.py
+++ b/servo/python/servo/post_build_commands.py
@@ -127,16 +127,17 @@ class PostBuildCommands(CommandBase):
                     args + params)
         elif browserhtml:
             browserhtml_path = find_dep_path_newest('browserhtml', args[0])
             if browserhtml_path is None:
                 print("Could not find browserhtml package; perhaps you haven't built Servo.")
                 return 1
             args = args + ['-w', '-b', '--pref', 'dom.mozbrowser.enabled',
                            path.join(browserhtml_path, 'out', 'index.html')]
+            args = args + params
         else:
             args = args + params
 
         try:
             check_call(args, env=env)
         except subprocess.CalledProcessError as e:
             print("Servo exited with return value %d" % e.returncode)
             return e.returncode