Bug 1630229: Part 8 - Stop throwing AssertionError for binding of defunct ServiceAllocator.InstanceInfo; r=geckoview-reviewers,owlish
☠☠ backed out by c8e34e81ac8a ☠ ☠
authorAaron Klotz <aklotz@mozilla.com>
Thu, 21 May 2020 17:53:08 +0000
changeset 531475 e562d64f2bf9a26db09e338b701f98d11e1d2629
parent 531474 7ded7f391f1b90c8ccc81bf151d289a802470317
child 531476 78bb6fa8acbc77de17ad51b22003127f41e3c104
push id37440
push userabutkovits@mozilla.com
push dateFri, 22 May 2020 09:43:16 +0000
treeherdermozilla-central@fbf71e4d2e21 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgeckoview-reviewers, owlish
bugs1630229
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1630229: Part 8 - Stop throwing AssertionError for binding of defunct ServiceAllocator.InstanceInfo; r=geckoview-reviewers,owlish I'm keeping this patch as simple as possible so that we can uplift to beta. I'll sort out the rest of this in follow-up bugs. Differential Revision: https://phabricator.services.mozilla.com/D76333
mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/ServiceAllocator.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/ServiceAllocator.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/ServiceAllocator.java
@@ -209,21 +209,17 @@ import java.util.Map.Entry;
 
         public GeckoProcessType getType() {
             return mType;
         }
 
         protected boolean bindService() {
             if (mIsDefunct) {
                 final String errorMsg = "Attempt to bind a defunct InstanceInfo for " + mType + " child process";
-                if (BuildConfig.DEBUG) {
-                    throw new AssertionError(errorMsg);
-                } else {
-                    throw new BindException(errorMsg);
-                }
+                throw new BindException(errorMsg);
             }
 
             return updateBindings();
         }
 
         /**
          * Unbinds the service described by |this| and releases our unique ID. This method may
          * safely be called multiple times even if we are already defunct.